From: Ammar Faizi <[email protected]>
To: Jens Axboe <[email protected]>,
Pavel Begunkov <[email protected]>,
io-uring Mailing List <[email protected]>,
Bedirhan KURT <[email protected]>
Cc: Louvian Lyndal <[email protected]>,
Ammar Faizi <[email protected]>
Subject: Re: [PATCH v1 RFC liburing 6/6] src/{queue,register,setup}: Clean up unused includes
Date: Thu, 7 Oct 2021 06:04:08 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On Thu, Oct 7, 2021 at 1:45 AM Bedirhan KURT <[email protected]> wrote:
>
> Ammar,
>
> As you told me through Telegram, I have reviewed your patch but
> aren't inclusions important for some functions and/or commands
> to work on compiling process?
>
> I mean you surely know more about this but, from what I know
> with my Android development experience, omitting/removing
> inclusions and/or imports from files to be compiled or
> scripts to be used might cause issues during
> compilation/booting/usage process so I guess those
> inclusions were just unnecessary?
>
> I'm also aware that Android is no match with Linux kernel but
> I just wanted to point that out.
>
> Regards,
>
> Bedirhan KURT.
>
Hmmm...
I don't fully understand your comment. But as far as I can tell, those
inclusions are duplicate. We have them in the lib.h and syscall.h
after these patches. If this removal caused a compilation problem, I
would have caught that before sending these patches as I've at least
built it.
--
Ammar Faizi
next parent reply other threads:[~2021-10-06 23:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[email protected]>
2021-10-06 23:04 ` Ammar Faizi [this message]
2021-10-06 14:49 [PATCHSET v1 RFC liburing 0/6] Add no libc support for x86-64 arch Ammar Faizi
2021-10-06 14:49 ` [PATCH v1 RFC liburing 6/6] src/{queue,register,setup}: Clean up unused includes Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211006230408.1210525-1-ammar.faizi@students.amikom.ac.id \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox