From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1A1EC433F5 for ; Thu, 18 Nov 2021 01:20:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A20C961B64 for ; Thu, 18 Nov 2021 01:20:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242235AbhKRBX2 (ORCPT ); Wed, 17 Nov 2021 20:23:28 -0500 Received: from dcvr.yhbt.net ([64.71.152.64]:36178 "EHLO dcvr.yhbt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242201AbhKRBXT (ORCPT ); Wed, 17 Nov 2021 20:23:19 -0500 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id A79271F9F4; Thu, 18 Nov 2021 01:20:19 +0000 (UTC) Date: Thu, 18 Nov 2021 01:20:19 +0000 From: Eric Wong To: Stefan Metzmacher Cc: io-uring@vger.kernel.org, Liu Changcheng Subject: Re: [PATCH 3/4] debian/rules: fix for newer debhelper Message-ID: <20211118012019.M599810@dcvr> References: <20211116224456.244746-1-e@80x24.org> <20211116224456.244746-4-e@80x24.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Stefan Metzmacher wrote: > > +# --add-udeb is needed for <= 12.3, and breaks with auto-detection > > +# on debhelper 13.3.4, at least > > + if perl -MDebian::Debhelper::Dh_Version -e \ > > + 'exit(eval("v$$Debian::Debhelper::Dh_Version::version") le v12.3)'; \ > > + then dh_makeshlibs -a; else \ > > + dh_makeshlibs -a --add-udeb '$(libudeb)'; fi > > + > > I think this needs to be 'ge v12.3)' instead of 'le v12.3)' > otherwise I still get the above error on ubuntu 20.04. It should be 'lt v12.3', actually. The Perl exit() with a falsy value means it's `true' for the `if' shell statement. Yes, I got confused, too :x Will fix.