From: Eric Wong <[email protected]>
To: Stefan Metzmacher <[email protected]>
Cc: [email protected],
Liu Changcheng <[email protected]>,
Bikal Lem <[email protected]>
Subject: Re: [PATCH 1/4] make-debs: fix version detection
Date: Thu, 18 Nov 2021 01:25:52 +0000 [thread overview]
Message-ID: <20211118012552.M795059@dcvr> (raw)
In-Reply-To: <[email protected]>
Stefan Metzmacher <[email protected]> wrote:
>
> Hi Eric,
>
> a comment on versioning in general not really about your commit.
>
> Is it still correct to have liburing1* in debian/control, shouldn't
> it be liburing2 now?
Yes, I'll correct that in a reroll.
> Also shouldn't we get version= out of liburing.spec as that seems to contain the current
> version number... instead of using git describe --match "lib*" | cut -d '-' -f 2
Agreed. I've also got patches on the way which will
allow building .debs without git at all.
> I also noticed that this
> commit c0b43df28a982747e081343f23289357ab4615db
> Author: Bikal Lem <[email protected]>
> Date: Mon Nov 15 13:09:30 2021 +0000
>
> src/Makefile: use VERSION variable consistently
>
> src/Makefile defines incorrect 'liburing.so' version, i.e 2.1 as
> opposed to 2.2. This commit makes src/Makefile use correct version
> defined in liburing.spec. Along the way we refactor the use of common
> variables into Makefile.common and include it into both src/Makefile
> and Makefile.
>
> Signed-off-by: Bikal Lem <[email protected]>
>
> changed the library soname from liburing.so.2 to just liburing.so, which seems wrong.
Separate issue, but yes, I'm inclined to agree with Stefan that
the ".2" should remain. (I'm not an expert in library/packaging
issues by any means; I just want the ability to cleanly
uninstall/upgrade via debs)
next prev parent reply other threads:[~2021-11-18 1:25 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 22:44 [PATCH 0/4] liburing debian packaging fixes Eric Wong
2021-11-16 22:44 ` [PATCH 1/4] make-debs: fix version detection Eric Wong
2021-11-17 10:17 ` Stefan Metzmacher
2021-11-18 1:25 ` Eric Wong [this message]
2021-11-16 22:44 ` [PATCH 2/4] debian: avoid prompting package builder for signature Eric Wong
2021-11-17 10:01 ` Stefan Metzmacher
2021-11-18 3:14 ` Eric Wong
2021-11-16 22:44 ` [PATCH 3/4] debian/rules: fix for newer debhelper Eric Wong
2021-11-17 10:04 ` Stefan Metzmacher
2021-11-18 1:20 ` Eric Wong
2021-11-16 22:44 ` [PATCH 4/4] debian/rules: support parallel build Eric Wong
2021-11-18 3:10 ` [PATCH v2 0/7] liburing debian packaging fixes Eric Wong
2021-11-18 3:10 ` [PATCH v2 1/7] make-debs: fix version detection Eric Wong
2021-11-18 3:10 ` [PATCH v2 2/7] debian: avoid prompting package builder for signature Eric Wong
2021-11-18 3:10 ` [PATCH v2 3/7] debian/rules: fix for newer debhelper Eric Wong
2021-11-18 4:42 ` Stefan Metzmacher
2021-11-18 5:11 ` Eric Wong
2021-11-18 5:35 ` Eric Wong
2021-11-18 14:37 ` Stefan Metzmacher
2021-11-18 3:10 ` [PATCH v2 4/7] debian/rules: support parallel build Eric Wong
2021-11-18 3:10 ` [PATCH v2 5/7] debian: rename package to liburing2 to match .so version Eric Wong
2021-11-18 3:10 ` [PATCH v2 6/7] make-debs: use version from RPM .spec Eric Wong
2021-11-18 3:10 ` [PATCH v2 7/7] make-debs: remove dependency on git Eric Wong
2021-11-18 18:50 ` [PATCHv2 8/7] debian/rules: fix version comparison for Ubuntu Eric Wong
2022-01-21 18:26 ` [PULL|PATCH v3 0/7] liburing debian packaging fixes Eric Wong
2022-01-21 18:26 ` [PATCH v3 1/7] make-debs: fix version detection Eric Wong
2022-01-21 18:26 ` [PATCH v3 2/7] debian: avoid prompting package builder for signature Eric Wong
2022-01-21 18:26 ` [PATCH v3 3/7] debian/rules: fix for newer debhelper Eric Wong
2022-01-21 18:26 ` [PATCH v3 4/7] debian/rules: support parallel build Eric Wong
2022-01-21 18:26 ` [PATCH v3 5/7] debian: rename package to liburing2 to match .so version Eric Wong
2022-01-21 18:26 ` [PATCH v3 6/7] make-debs: use version from RPM .spec Eric Wong
2022-01-21 18:26 ` [PATCH v3 7/7] make-debs: remove dependency on git Eric Wong
2022-04-03 8:48 ` [PULL|PATCH v3 0/7] liburing debian packaging fixes Eric Wong
2022-04-03 14:54 ` Jens Axboe
2022-04-03 20:43 ` Eric Wong
2022-04-04 16:13 ` Stefan Metzmacher
2022-04-04 16:17 ` Stefan Metzmacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211118012552.M795059@dcvr \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox