public inbox for [email protected]
 help / color / mirror / Atom feed
From: Eric Wong <[email protected]>
To: [email protected]
Cc: Liu Changcheng <[email protected]>,
	Stefan Metzmacher <[email protected]>
Subject: [PATCH v2 0/7] liburing debian packaging fixes
Date: Thu, 18 Nov 2021 03:10:09 +0000	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

3 new patches on top of the original series, this addresses
the issues noticed by Stefan in the original series.

I'm getting these warnings from dpkg-gensymbols, but AFAIK
they're not fatal:

  dpkg-gensymbols: warning: new libraries appeared in the symbols file: liburing.so
  dpkg-gensymbols: warning: some libraries disappeared in the symbols file: liburing.so.1
  dpkg-gensymbols: warning: debian/liburing1/DEBIAN/symbols doesn't match completely debian/liburing1.symbols
  --- debian/liburing1.symbols (liburing1_2.1-1_amd64)
  +++ dpkg-gensymbolsHfPj7C	2021-11-18 03:07:48.131823699 +0000
  @@ -1,32 +1,41 @@
  -liburing.so.1 liburing1 #MINVER#
  - (symver)LIBURING_0.1 0.1-1
  - (symver)LIBURING_0.2 0.2-1
  - (symver)LIBURING_0.3 0.3-1
  - (symver)LIBURING_0.4 0.4-1
  - (symver)LIBURING_0.5 0.5-1
  - (symver)LIBURING_0.6 0.6-1
  - (symver)LIBURING_0.7 0.7-1
  - __io_uring_get_cqe@LIBURING_0.2 0.2-1
  - io_uring_get_probe@LIBURING_0.4 0.4-1
  - io_uring_get_probe_ring@LIBURING_0.4 0.4-1
  - io_uring_get_sqe@LIBURING_0.1 0.1-1
  - io_uring_peek_batch_cqe@LIBURING_0.2 0.2-1
  - io_uring_queue_exit@LIBURING_0.1 0.1-1
  - io_uring_queue_init@LIBURING_0.1 0.1-1
  - io_uring_queue_init_params@LIBURING_0.2 0.2-1
  - io_uring_queue_mmap@LIBURING_0.1 0.1-1
  - io_uring_register_buffers@LIBURING_0.1 0.1-1
  - io_uring_register_eventfd@LIBURING_0.1 0.1-1
  - io_uring_register_eventfd_async@LIBURING_0.6 0.6-1
  - io_uring_register_files@LIBURING_0.1 0.1-1
  - io_uring_register_files_update@LIBURING_0.2 0.2-1
  - io_uring_register_personality@LIBURING_0.4 0.4-1
  - io_uring_register_probe@LIBURING_0.4 0.4-1
  - io_uring_ring_dontfork@LIBURING_0.4 0.4-1
  - io_uring_submit@LIBURING_0.1 0.1-1
  - io_uring_submit_and_wait@LIBURING_0.1 0.1-1
  - io_uring_unregister_buffers@LIBURING_0.1 0.1-1
  - io_uring_unregister_files@LIBURING_0.1 0.1-1
  - io_uring_unregister_personality@LIBURING_0.4 0.4-1
  - io_uring_wait_cqe_timeout@LIBURING_0.2 0.2-1
  - io_uring_wait_cqes@LIBURING_0.2 0.2-1
  +liburing.so liburing1 #MINVER#
  + LIBURING_2.0@LIBURING_2.0 2.1-1
  + LIBURING_2.1@LIBURING_2.1 2.1-1
  + LIBURING_2.2@LIBURING_2.2 2.1-1
  + __io_uring_get_cqe@LIBURING_2.0 2.1-1
  + __io_uring_sqring_wait@LIBURING_2.0 2.1-1
  + io_uring_free_probe@LIBURING_2.0 2.1-1
  + io_uring_get_probe@LIBURING_2.0 2.1-1
  + io_uring_get_probe_ring@LIBURING_2.0 2.1-1
  + io_uring_get_sqe@LIBURING_2.0 2.1-1
  + io_uring_mlock_size@LIBURING_2.1 2.1-1
  + io_uring_mlock_size_params@LIBURING_2.1 2.1-1
  + io_uring_peek_batch_cqe@LIBURING_2.0 2.1-1
  + io_uring_queue_exit@LIBURING_2.0 2.1-1
  + io_uring_queue_init@LIBURING_2.0 2.1-1
  + io_uring_queue_init_params@LIBURING_2.0 2.1-1
  + io_uring_queue_mmap@LIBURING_2.0 2.1-1
  + io_uring_register_buffers@LIBURING_2.0 2.1-1
  + io_uring_register_buffers_tags@LIBURING_2.1 2.1-1
  + io_uring_register_buffers_update_tag@LIBURING_2.1 2.1-1
  + io_uring_register_eventfd@LIBURING_2.0 2.1-1
  + io_uring_register_eventfd_async@LIBURING_2.0 2.1-1
  + io_uring_register_files@LIBURING_2.0 2.1-1
  + io_uring_register_files_tags@LIBURING_2.1 2.1-1
  + io_uring_register_files_update@LIBURING_2.0 2.1-1
  + io_uring_register_files_update_tag@LIBURING_2.1 2.1-1
  + io_uring_register_iowq_aff@LIBURING_2.1 2.1-1
  + io_uring_register_iowq_max_workers@LIBURING_2.1 2.1-1
  + io_uring_register_personality@LIBURING_2.0 2.1-1
  + io_uring_register_probe@LIBURING_2.0 2.1-1
  + io_uring_ring_dontfork@LIBURING_2.0 2.1-1
  + io_uring_submit@LIBURING_2.0 2.1-1
  + io_uring_submit_and_wait@LIBURING_2.0 2.1-1
  + io_uring_submit_and_wait_timeout@LIBURING_2.2 2.1-1
  + io_uring_unregister_buffers@LIBURING_2.0 2.1-1
  + io_uring_unregister_eventfd@LIBURING_2.0 2.1-1
  + io_uring_unregister_files@LIBURING_2.0 2.1-1
  + io_uring_unregister_iowq_aff@LIBURING_2.1 2.1-1
  + io_uring_unregister_personality@LIBURING_2.0 2.1-1
  + io_uring_wait_cqe_timeout@LIBURING_2.0 2.1-1
  + io_uring_wait_cqes@LIBURING_2.0 2.1-1

Eric Wong (7):
  make-debs: fix version detection
  debian: avoid prompting package builder for signature
  debian/rules: fix for newer debhelper
  debian/rules: support parallel build
  debian: rename package to liburing2 to match .so version
  make-debs: use version from RPM .spec
  make-debs: remove dependency on git

 Makefile                                      |  5 ++++-
 debian/changelog                              |  6 ++++++
 debian/control                                |  6 +++---
 ...g1-udeb.install => liburing2-udeb.install} |  0
 .../{liburing1.install => liburing2.install}  |  0
 .../{liburing1.symbols => liburing2.symbols}  |  2 +-
 debian/rules                                  | 21 +++++++++++++++++--
 make-debs.sh                                  | 19 ++++++++++++-----
 8 files changed, 47 insertions(+), 12 deletions(-)
 rename debian/{liburing1-udeb.install => liburing2-udeb.install} (100%)
 rename debian/{liburing1.install => liburing2.install} (100%)
 rename debian/{liburing1.symbols => liburing2.symbols} (97%)

Range-diff against v1:
1:  d3d6028 = 1:  bc20a43 make-debs: fix version detection
2:  49d995f ! 2:  c61015a debian: avoid prompting package builder for signature
    @@ Commit message
         them locally on a development system which may not have private
         keys.
     
    +    While "debuild -us -uc" could also be used to avoid signatures,
    +    using "UNRELEASED" also helps communicate to changelog readers
    +    that the package(s) are not from an official Debian source.
    +
         AFAIK the official Debian package is maintained separately at
         <https://git.hadrons.org/git/debian/pkgs/liburing.git>,
         and won't be affected by this change.
3:  2774a5e ! 3:  8a10758 debian/rules: fix for newer debhelper
    @@ Commit message
     
         Reading the current dh_makeshlibs(1) manpage reveals --add-udeb
         is nowadays implicit as of debhelper 12.3 and no longer
    -    necessary.  Compatibility with Debian oldstable (buster) remains
    -    intact.  Tested with debhelper 12.1.1 on Debian 10.x (buster)
    -    and debhelper 13.3.4 on Debian 11.x (bullseye).
    +    necessary.  Compatibility with older debhelper on Debian
    +    oldstable (buster) remains intact.  Tested with debhelper 12.1.1
    +    on Debian 10.x (buster) and debhelper 13.3.4 on Debian 11.x
    +    (bullseye).
     
         Signed-off-by: Eric Wong <[email protected]>
     
    @@ debian/rules: binary-arch: install-arch
      	dh_fixperms -a
     -	dh_makeshlibs -a --add-udeb '$(libudeb)'
     +
    -+# --add-udeb is needed for <= 12.3, and breaks with auto-detection
    ++# --add-udeb is needed for < 12.3, and breaks with auto-detection
     +#  on debhelper 13.3.4, at least
     +	if perl -MDebian::Debhelper::Dh_Version -e \
    -+	'exit(eval("v$$Debian::Debhelper::Dh_Version::version") le v12.3)'; \
    ++	'exit(eval("v$$Debian::Debhelper::Dh_Version::version") lt v12.3)'; \
     +		then dh_makeshlibs -a; else \
     +		dh_makeshlibs -a --add-udeb '$(libudeb)'; fi
     +
4:  cbc950c = 4:  ca43b96 debian/rules: support parallel build
-:  ------- > 5:  c33d422 debian: rename package to liburing2 to match .so version
-:  ------- > 6:  9e27918 make-debs: use version from RPM .spec
-:  ------- > 7:  bbc1200 make-debs: remove dependency on git

  parent reply	other threads:[~2021-11-18  3:10 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 22:44 [PATCH 0/4] liburing debian packaging fixes Eric Wong
2021-11-16 22:44 ` [PATCH 1/4] make-debs: fix version detection Eric Wong
2021-11-17 10:17   ` Stefan Metzmacher
2021-11-18  1:25     ` Eric Wong
2021-11-16 22:44 ` [PATCH 2/4] debian: avoid prompting package builder for signature Eric Wong
2021-11-17 10:01   ` Stefan Metzmacher
2021-11-18  3:14     ` Eric Wong
2021-11-16 22:44 ` [PATCH 3/4] debian/rules: fix for newer debhelper Eric Wong
2021-11-17 10:04   ` Stefan Metzmacher
2021-11-18  1:20     ` Eric Wong
2021-11-16 22:44 ` [PATCH 4/4] debian/rules: support parallel build Eric Wong
2021-11-18  3:10 ` Eric Wong [this message]
2021-11-18  3:10   ` [PATCH v2 1/7] make-debs: fix version detection Eric Wong
2021-11-18  3:10   ` [PATCH v2 2/7] debian: avoid prompting package builder for signature Eric Wong
2021-11-18  3:10   ` [PATCH v2 3/7] debian/rules: fix for newer debhelper Eric Wong
2021-11-18  4:42     ` Stefan Metzmacher
2021-11-18  5:11       ` Eric Wong
2021-11-18  5:35         ` Eric Wong
2021-11-18 14:37           ` Stefan Metzmacher
2021-11-18  3:10   ` [PATCH v2 4/7] debian/rules: support parallel build Eric Wong
2021-11-18  3:10   ` [PATCH v2 5/7] debian: rename package to liburing2 to match .so version Eric Wong
2021-11-18  3:10   ` [PATCH v2 6/7] make-debs: use version from RPM .spec Eric Wong
2021-11-18  3:10   ` [PATCH v2 7/7] make-debs: remove dependency on git Eric Wong
2021-11-18 18:50   ` [PATCHv2 8/7] debian/rules: fix version comparison for Ubuntu Eric Wong
2022-01-21 18:26 ` [PULL|PATCH v3 0/7] liburing debian packaging fixes Eric Wong
2022-01-21 18:26   ` [PATCH v3 1/7] make-debs: fix version detection Eric Wong
2022-01-21 18:26   ` [PATCH v3 2/7] debian: avoid prompting package builder for signature Eric Wong
2022-01-21 18:26   ` [PATCH v3 3/7] debian/rules: fix for newer debhelper Eric Wong
2022-01-21 18:26   ` [PATCH v3 4/7] debian/rules: support parallel build Eric Wong
2022-01-21 18:26   ` [PATCH v3 5/7] debian: rename package to liburing2 to match .so version Eric Wong
2022-01-21 18:26   ` [PATCH v3 6/7] make-debs: use version from RPM .spec Eric Wong
2022-01-21 18:26   ` [PATCH v3 7/7] make-debs: remove dependency on git Eric Wong
2022-04-03  8:48   ` [PULL|PATCH v3 0/7] liburing debian packaging fixes Eric Wong
2022-04-03 14:54     ` Jens Axboe
2022-04-03 20:43       ` Eric Wong
2022-04-04 16:13       ` Stefan Metzmacher
2022-04-04 16:17         ` Stefan Metzmacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox