From: Hao Xu <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected], Pavel Begunkov <[email protected]>,
Joseph Qi <[email protected]>
Subject: [PATCH 6/9] io-wq: add infra data structure for fixed workers
Date: Wed, 24 Nov 2021 12:46:45 +0800 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
Add data sttructure and basic initialization for fixed worker.
Signed-off-by: Hao Xu <[email protected]>
---
fs/io-wq.c | 63 ++++++++++++++++++++++++++++++++++++++----------------
1 file changed, 45 insertions(+), 18 deletions(-)
diff --git a/fs/io-wq.c b/fs/io-wq.c
index 44c3e344c5d6..fcdfbb904cdf 100644
--- a/fs/io-wq.c
+++ b/fs/io-wq.c
@@ -25,6 +25,7 @@ enum {
IO_WORKER_F_RUNNING = 2, /* account as running */
IO_WORKER_F_FREE = 4, /* worker on free list */
IO_WORKER_F_BOUND = 8, /* is doing bounded work */
+ IO_WORKER_F_FIXED = 16, /* is a fixed worker */
};
enum {
@@ -33,6 +34,35 @@ enum {
enum {
IO_ACCT_STALLED_BIT = 0, /* stalled on hash */
+ IO_ACCT_IN_WORKER_BIT,
+};
+
+struct io_wqe_acct {
+ union {
+ unsigned int nr_workers;
+ unsigned int nr_works;
+ };
+ union {
+ unsigned int max_workers;
+ unsigned int max_works;
+ };
+ int index;
+ atomic_t nr_running;
+ raw_spinlock_t lock;
+ struct io_wq_work_list work_list;
+ unsigned long flags;
+
+ struct wait_queue_entry wait;
+ union {
+ struct io_wqe *wqe;
+ struct io_worker *worker;
+ };
+};
+
+enum {
+ IO_WQ_ACCT_BOUND,
+ IO_WQ_ACCT_UNBOUND,
+ IO_WQ_ACCT_NR,
};
/*
@@ -59,6 +89,9 @@ struct io_worker {
struct rcu_head rcu;
struct work_struct work;
};
+ bool fixed;
+ unsigned int index;
+ struct io_wqe_acct acct;
};
#if BITS_PER_LONG == 64
@@ -69,24 +102,6 @@ struct io_worker {
#define IO_WQ_NR_HASH_BUCKETS (1u << IO_WQ_HASH_ORDER)
-struct io_wqe_acct {
- unsigned nr_workers;
- unsigned max_workers;
- int index;
- atomic_t nr_running;
- raw_spinlock_t lock;
- struct io_wq_work_list work_list;
- unsigned long flags;
- struct wait_queue_entry wait;
- struct io_wqe *wqe;
-};
-
-enum {
- IO_WQ_ACCT_BOUND,
- IO_WQ_ACCT_UNBOUND,
- IO_WQ_ACCT_NR,
-};
-
/*
* Per-node worker thread pool
*/
@@ -103,6 +118,12 @@ struct io_wqe {
struct io_wq_work *hash_tail[IO_WQ_NR_HASH_BUCKETS];
cpumask_var_t cpu_mask;
+
+ raw_spinlock_t fixed_lock;
+ unsigned int max_fixed[IO_WQ_ACCT_NR];
+ unsigned int nr_fixed[IO_WQ_ACCT_NR];
+ unsigned int default_max_works[IO_WQ_ACCT_NR];
+ struct io_worker **fixed_workers[IO_WQ_ACCT_NR];
};
/*
@@ -1090,6 +1111,8 @@ static int io_wqe_hash_wake(struct wait_queue_entry *wait, unsigned mode,
return 1;
}
+#define DEFAULT_MAX_FIXED_WORKERS 0
+#define DEFAULT_MAX_FIXED_WORKS 0
struct io_wq *io_wq_create(unsigned bounded, struct io_wq_data *data)
{
int ret, node, i;
@@ -1141,9 +1164,12 @@ struct io_wq *io_wq_create(unsigned bounded, struct io_wq_data *data)
INIT_LIST_HEAD(&acct->wait.entry);
acct->wait.func = io_wqe_hash_wake;
acct->wqe = wqe;
+ wqe->max_fixed[i] = DEFAULT_MAX_FIXED_WORKERS;
+ wqe->default_max_works[i] = DEFAULT_MAX_FIXED_WORKS;
}
wqe->wq = wq;
raw_spin_lock_init(&wqe->lock);
+ raw_spin_lock_init(&wqe->fixed_lock);
INIT_HLIST_NULLS_HEAD(&wqe->free_list, 0);
INIT_LIST_HEAD(&wqe->all_list);
}
@@ -1232,6 +1258,7 @@ static void io_wq_destroy(struct io_wq *wq)
};
io_wqe_cancel_pending_work(wqe, &match);
free_cpumask_var(wqe->cpu_mask);
+ kfree(wqe->fixed_workers);
kfree(wqe);
}
io_wq_put_hash(wq->hash);
--
2.24.4
next prev parent reply other threads:[~2021-11-24 4:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 4:46 [RFC 0/9] fixed worker: a new way to handle io works Hao Xu
2021-11-24 4:46 ` [PATCH 1/9] io-wq: decouple work_list protection from the big wqe->lock Hao Xu
2021-11-24 4:46 ` [PATCH 2/9] io-wq: reduce acct->lock crossing functions lock/unlock Hao Xu
2021-11-24 4:46 ` [PATCH 3/9] io-wq: update check condition for lock Hao Xu
2021-11-25 14:47 ` Pavel Begunkov
2021-11-30 3:32 ` Hao Xu
2021-11-24 4:46 ` [PATCH 4/9] io-wq: use IO_WQ_ACCT_NR rather than hardcoded number Hao Xu
2021-11-24 4:46 ` [PATCH 5/9] io-wq: move hash wait entry to io_wqe_acct Hao Xu
2021-11-24 4:46 ` Hao Xu [this message]
2021-11-24 4:46 ` [PATCH 7/9] io-wq: implement fixed worker logic Hao Xu
2021-11-24 4:46 ` [PATCH 8/9] io-wq: batch the handling of fixed worker private works Hao Xu
2021-11-24 4:46 ` [PATCH 9/9] io-wq: small optimization for __io_worker_busy() Hao Xu
2021-11-25 15:09 ` [RFC 0/9] fixed worker: a new way to handle io works Pavel Begunkov
2021-11-30 3:48 ` Hao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox