From: Usama Arif <[email protected]>
To: [email protected], [email protected],
[email protected], [email protected]
Cc: [email protected], Usama Arif <[email protected]>
Subject: [PATCH v4 0/3] io_uring: avoid ring quiesce in io_uring_register for eventfd opcodes
Date: Thu, 3 Feb 2022 18:24:38 +0000 [thread overview]
Message-ID: <[email protected]> (raw)
This is done by creating a new RCU data structure (io_ev_fd) as part of
io_ring_ctx that holds the eventfd_ctx, with reads to the structure protected
by rcu_read_lock and writes (register/unregister calls) protected by a mutex.
With the above approach ring quiesce can be avoided which is much more
expensive then using RCU lock. On the system tested, io_uring_reigster with
IORING_REGISTER_EVENTFD takes less than 1ms with RCU lock, compared to 15ms
before with ring quiesce.
The first patch creates the RCU protected data structure and removes ring
quiesce for IORING_REGISTER_EVENTFD and IORING_UNREGISTER_EVENTFD.
The second patch builds on top of the first patch and removes ring quiesce
for IORING_REGISTER_EVENTFD_ASYNC.
---
v3->v4:
- Switch back to call_rcu and use rcu_barrier incase io_eventfd_register fails
to make sure all rcu callbacks have finished.
v2->v3:
- Switched to using synchronize_rcu from call_rcu in io_eventfd_unregister.
v1->v2:
- Added patch to remove eventfd from tracepoint (Patch 1) (Jens Axboe)
- Made the code of io_should_trigger_evfd as part of io_eventfd_signal (Jens Axboe)
Usama Arif (3):
io_uring: remove trace for eventfd
io_uring: avoid ring quiesce while registering/unregistering eventfd
io_uring: avoid ring quiesce for IORING_REGISTER_EVENTFD_ASYNC
fs/io_uring.c | 127 +++++++++++++++++++++++---------
include/trace/events/io_uring.h | 13 ++--
2 files changed, 96 insertions(+), 44 deletions(-)
--
2.25.1
next reply other threads:[~2022-02-03 18:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 18:24 Usama Arif [this message]
2022-02-03 18:24 ` [PATCH v4 1/3] io_uring: remove trace for eventfd Usama Arif
2022-02-03 18:24 ` [PATCH v4 2/3] io_uring: avoid ring quiesce while registering/unregistering eventfd Usama Arif
2022-02-03 18:49 ` Jens Axboe
2022-02-03 19:05 ` [External] " Usama Arif
2022-02-03 19:12 ` Jens Axboe
2022-02-03 23:37 ` Usama Arif
2022-02-03 18:24 ` [PATCH v4 3/3] io_uring: avoid ring quiesce for IORING_REGISTER_EVENTFD_ASYNC Usama Arif
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox