public inbox for [email protected]
 help / color / mirror / Atom feed
From: Jiapeng Chong <[email protected]>
To: [email protected]
Cc: [email protected], [email protected],
	[email protected],
	Jiapeng Chong <[email protected]>,
	Abaci Robot <[email protected]>
Subject: [PATCH] io_uring: Fix uninitialized use of ret in io_eventfd_register()
Date: Wed,  9 Feb 2022 18:26:37 +0800	[thread overview]
Message-ID: <[email protected]> (raw)

In some scenarios, ret is not assigned in the whole process, so it
needs to be initialized at the beginning.

Clean up the following clang warning:

fs/io_uring.c:9373:13: note: initialize the variable 'ret' to silence
this warning.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
 fs/io_uring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 5479f0607430..7f277890f1ec 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -9370,7 +9370,7 @@ static int io_eventfd_register(struct io_ring_ctx *ctx, void __user *arg,
 {
 	struct io_ev_fd *ev_fd;
 	__s32 __user *fds = arg;
-	int fd, ret;
+	int fd, ret = 0;
 
 	ev_fd = rcu_dereference_protected(ctx->io_ev_fd,
 					lockdep_is_held(&ctx->uring_lock));
-- 
2.20.1.7.g153144c


             reply	other threads:[~2022-02-09 10:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09 10:26 Jiapeng Chong [this message]
2022-02-09 11:06 ` [PATCH] io_uring: Fix uninitialized use of ret in io_eventfd_register() Ammar Faizi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220209102637.34088-1-jiapeng.chong@linux.alibaba.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox