From: kernel test robot <[email protected]>
To: Olivier Langlois <[email protected]>, Jens Axboe <[email protected]>
Cc: [email protected], [email protected],
Pavel Begunkov <[email protected]>,
Hao Xu <[email protected]>,
io-uring <[email protected]>,
linux-kernel <[email protected]>
Subject: Re: [PATCH v2] io_uring: Add support for napi_busy_poll
Date: Mon, 28 Feb 2022 04:21:11 +0800 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <53ae4884ede7faab1f409ec635f723a0745d3656.1645981935.git.olivier@trillion01.com>
Hi Olivier,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.17-rc5 next-20220225]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Olivier-Langlois/io_uring-Add-support-for-napi_busy_poll/20220228-012140
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2293be58d6a18cab800e25e42081bacb75c05752
config: mips-qi_lb60_defconfig (https://download.01.org/0day-ci/archive/20220228/[email protected]/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://github.com/0day-ci/linux/commit/65e72f78c66272f7cf0e87dfeef88f5b79de2d91
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Olivier-Langlois/io_uring-Add-support-for-napi_busy_poll/20220228-012140
git checkout 65e72f78c66272f7cf0e87dfeef88f5b79de2d91
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All warnings (new ones prefixed by >>):
>> fs/io_uring.c:7840:3: warning: comparison of distinct pointer types ('typeof ((to)) *' (aka 'long long *') and 'uint64_t *' (aka 'unsigned long long *')) [-Wcompare-distinct-pointer-types]
do_div(to, 1000);
^~~~~~~~~~~~~~~~
include/asm-generic/div64.h:222:28: note: expanded from macro 'do_div'
(void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~
1 warning generated.
vim +7840 fs/io_uring.c
7826
7827 #ifdef CONFIG_NET_RX_BUSY_POLL
7828 static void io_adjust_busy_loop_timeout(struct timespec64 *ts,
7829 struct io_wait_queue *iowq)
7830 {
7831 unsigned busy_poll_to = READ_ONCE(sysctl_net_busy_poll);
7832 struct timespec64 pollto = ns_to_timespec64(1000 * (s64)busy_poll_to);
7833
7834 if (timespec64_compare(ts, &pollto) > 0) {
7835 *ts = timespec64_sub(*ts, pollto);
7836 iowq->busy_poll_to = busy_poll_to;
7837 } else {
7838 s64 to = timespec64_to_ns(ts);
7839
> 7840 do_div(to, 1000);
7841 iowq->busy_poll_to = to;
7842 ts->tv_sec = 0;
7843 ts->tv_nsec = 0;
7844 }
7845 }
7846
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
next prev parent reply other threads:[~2022-02-27 20:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 17:20 [PATCH v2] io_uring: Add support for napi_busy_poll Olivier Langlois
2022-02-27 20:21 ` kernel test robot [this message]
2022-02-27 20:41 ` kernel test robot
2022-02-27 21:42 ` kernel test robot
2022-02-28 7:00 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox