From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A0D1C433F5 for ; Thu, 10 Mar 2022 08:37:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234074AbiCJIiU (ORCPT ); Thu, 10 Mar 2022 03:38:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240476AbiCJIh7 (ORCPT ); Thu, 10 Mar 2022 03:37:59 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48E87136EE3; Thu, 10 Mar 2022 00:36:57 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id D4F5768AFE; Thu, 10 Mar 2022 09:36:52 +0100 (CET) Date: Thu, 10 Mar 2022 09:36:52 +0100 From: Christoph Hellwig To: Kanchan Joshi Cc: axboe@kernel.dk, hch@lst.de, kbusch@kernel.org, asml.silence@gmail.com, io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, sbates@raithlin.com, logang@deltatee.com, pankydev8@gmail.com, javier@javigon.com, mcgrof@kernel.org, a.manzanares@samsung.com, joshiiitr@gmail.com, anuj20.g@samsung.com Subject: Re: [PATCH 17/17] nvme: enable non-inline passthru commands Message-ID: <20220310083652.GF26614@lst.de> References: <20220308152105.309618-1-joshi.k@samsung.com> <20220308152105.309618-18-joshi.k@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220308152105.309618-18-joshi.k@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Tue, Mar 08, 2022 at 08:51:05PM +0530, Kanchan Joshi wrote: > From: Anuj Gupta > > On submission,just fetch the commmand from userspace pointer and reuse > everything else. On completion, update the result field inside the > passthru command. What is that supposed to mean? What is the reason to do it. Remember to always document the why in commit logs. > > +static inline bool is_inline_rw(struct io_uring_cmd *ioucmd, struct nvme_command *cmd) Overly long line.