From: Dylan Yudaken <[email protected]>
To: Jens Axboe <[email protected]>,
Pavel Begunkov <[email protected]>,
<[email protected]>
Cc: <[email protected]>, Dylan Yudaken <[email protected]>
Subject: [PATCH] io_uring: make tracing format consistent
Date: Tue, 15 Mar 2022 13:48:29 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
Make the tracing formatting for user_data and flags consistent.
Having consistent formatting allows one for example to grep for a specific
user_data/flags and be able to trace a single sqe through easily.
Change user_data to be %llu everywhere, and flags to be %u. Additionally
remove the '=' for flags in io_uring_req_failed, again for consistency.
Signed-off-by: Dylan Yudaken <[email protected]>
---
include/trace/events/io_uring.h | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/include/trace/events/io_uring.h b/include/trace/events/io_uring.h
index 18d4341c581c..92446436b3ac 100644
--- a/include/trace/events/io_uring.h
+++ b/include/trace/events/io_uring.h
@@ -327,11 +327,11 @@ TRACE_EVENT(io_uring_complete,
TP_ARGS(ctx, req, user_data, res, cflags),
TP_STRUCT__entry (
- __field( void *, ctx )
- __field( void *, req )
- __field( u64, user_data )
- __field( int, res )
- __field( unsigned, cflags )
+ __field( void *, ctx )
+ __field( void *, req )
+ __field( unsigned long long, user_data )
+ __field( int, res )
+ __field( unsigned, cflags )
),
TP_fast_assign(
@@ -342,9 +342,9 @@ TRACE_EVENT(io_uring_complete,
__entry->cflags = cflags;
),
- TP_printk("ring %p, req %p, user_data 0x%llx, result %d, cflags %x",
+ TP_printk("ring %p, req %p, user_data %llu, result %d, cflags %u",
__entry->ctx, __entry->req,
- (unsigned long long)__entry->user_data,
+ __entry->user_data,
__entry->res, __entry->cflags)
);
@@ -530,7 +530,7 @@ TRACE_EVENT(io_uring_req_failed,
),
TP_printk("ring %p, req %p, user_data %llu, "
- "op %d, flags=0x%x, prio=%d, off=%llu, addr=%llu, "
+ "op %d, flags %u, prio=%d, off=%llu, addr=%llu, "
"len=%u, rw_flags=0x%x, buf_index=%d, "
"personality=%d, file_index=%d, pad=0x%llx/%llx, error=%d",
__entry->ctx, __entry->req, __entry->user_data,
base-commit: f3b6a41eb2bbdf545a42e54d637c34f4b1fdf5b9
--
2.30.2
next reply other threads:[~2022-03-15 20:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 20:48 Dylan Yudaken [this message]
2022-03-15 20:51 ` [PATCH] io_uring: make tracing format consistent Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox