From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 419FCC433F5 for ; Wed, 6 Apr 2022 07:03:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229513AbiDFHE6 (ORCPT ); Wed, 6 Apr 2022 03:04:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230201AbiDFGXc (ORCPT ); Wed, 6 Apr 2022 02:23:32 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 123E81D4C2E for ; Tue, 5 Apr 2022 22:23:33 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 3389D68AFE; Wed, 6 Apr 2022 07:23:30 +0200 (CEST) Date: Wed, 6 Apr 2022 07:23:30 +0200 From: Christoph Hellwig To: Kanchan Joshi Cc: Christoph Hellwig , Kanchan Joshi , Jens Axboe , io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, Pavel Begunkov , Ming Lei , Luis Chamberlain , Pankaj Raghav , Javier =?iso-8859-1?Q?Gonz=E1lez?= , Anuj Gupta Subject: Re: [RFC 5/5] nvme: wire-up support for async-passthru on char-device. Message-ID: <20220406052330.GA10320@lst.de> References: <20220401110310.611869-1-joshi.k@samsung.com> <20220401110310.611869-6-joshi.k@samsung.com> <20220404072016.GD444@lst.de> <20220405060224.GE23698@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Wed, Apr 06, 2022 at 10:50:14AM +0530, Kanchan Joshi wrote: > > > Also I think we'll want admin command passthrough on /dev/nvmeX as > > > well, but I'm fine solving the other items first. > > Sure, will add that in the second round. Should be fairly simple as we > can reuse io-command work anyway. Yes, I don't think it is a priority right now. And I'm actually glad you did this simple version first as that allows us to get the basics right first.