public inbox for [email protected]
 help / color / mirror / Atom feed
From: Stefan Roesch <[email protected]>
To: <[email protected]>, <[email protected]>
Cc: <[email protected]>
Subject: [PATCH v1 06/11] io_uring: modify io_get_cqe for CQE32
Date: Tue, 19 Apr 2022 13:56:19 -0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

Modify accesses to the CQE array to take large CQE's into account. The
index needs to be shifted by one for large CQE's.

Signed-off-by: Stefan Roesch <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
---
 fs/io_uring.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index c93a9353c88d..bd352815b9e7 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -1909,8 +1909,12 @@ static noinline struct io_uring_cqe *__io_get_cqe(struct io_ring_ctx *ctx)
 {
 	struct io_rings *rings = ctx->rings;
 	unsigned int off = ctx->cached_cq_tail & (ctx->cq_entries - 1);
+	unsigned int shift = 0;
 	unsigned int free, queued, len;
 
+	if (ctx->flags & IORING_SETUP_CQE32)
+		shift = 1;
+
 	/* userspace may cheat modifying the tail, be safe and do min */
 	queued = min(__io_cqring_events(ctx), ctx->cq_entries);
 	free = ctx->cq_entries - queued;
@@ -1922,12 +1926,13 @@ static noinline struct io_uring_cqe *__io_get_cqe(struct io_ring_ctx *ctx)
 	ctx->cached_cq_tail++;
 	ctx->cqe_cached = &rings->cqes[off];
 	ctx->cqe_sentinel = ctx->cqe_cached + len;
-	return ctx->cqe_cached++;
+	ctx->cqe_cached++;
+	return &rings->cqes[off << shift];
 }
 
 static inline struct io_uring_cqe *io_get_cqe(struct io_ring_ctx *ctx)
 {
-	if (likely(ctx->cqe_cached < ctx->cqe_sentinel)) {
+	if (likely(ctx->cqe_cached < ctx->cqe_sentinel && !(ctx->flags & IORING_SETUP_CQE32))) {
 		ctx->cached_cq_tail++;
 		return ctx->cqe_cached++;
 	}
-- 
2.30.2


  parent reply	other threads:[~2022-04-19 20:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19 20:56 [PATCH v1 00/11] add large CQE support for io-uring Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 01/11] io_uring: support CQE32 in io_uring_cqe Stefan Roesch
2022-04-22  1:51   ` Kanchan Joshi
2022-04-22  5:18     ` Kanchan Joshi
2022-04-22 21:26     ` Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 02/11] io_uring: wire up inline completion path for CQE32 Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 03/11] io_uring: change ring size calculation " Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 04/11] io_uring: add CQE32 setup processing Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 05/11] io_uring: add CQE32 completion processing Stefan Roesch
2022-04-19 20:56 ` Stefan Roesch [this message]
2022-04-19 20:56 ` [PATCH v1 07/11] io_uring: flush completions for CQE32 Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 08/11] io_uring: overflow processing " Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 09/11] io_uring: add tracing for additional CQE32 fields Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 10/11] io_uring: enable CQE32 Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 11/11] io_uring: support CQE32 for nop operation Stefan Roesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox