From: Kanchan Joshi <[email protected]>
To: Kanchan Joshi <[email protected]>
Cc: Stefan Roesch <[email protected]>,
[email protected], [email protected],
Jens Axboe <[email protected]>
Subject: Re: [PATCH v1 01/11] io_uring: support CQE32 in io_uring_cqe
Date: Fri, 22 Apr 2022 10:48:27 +0530 [thread overview]
Message-ID: <20220422051827.GC14949@test-zns> (raw)
In-Reply-To: <CA+1E3rLem2p+FMhni3DLek5Bcwt_HtYRFmfuQirdRhBEz=Qabg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2120 bytes --]
On Fri, Apr 22, 2022 at 07:21:12AM +0530, Kanchan Joshi wrote:
>On Thu, Apr 21, 2022 at 12:02 PM Stefan Roesch <[email protected]> wrote:
>>
>> This adds the struct io_uring_cqe_extra in the structure io_uring_cqe to
>> support large CQE's.
>>
>> Co-developed-by: Jens Axboe <[email protected]>
>> Signed-off-by: Stefan Roesch <[email protected]>
>> Signed-off-by: Jens Axboe <[email protected]>
>> ---
>> include/uapi/linux/io_uring.h | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h
>> index ee677dbd6a6d..6f9f9b6a9d15 100644
>> --- a/include/uapi/linux/io_uring.h
>> +++ b/include/uapi/linux/io_uring.h
>> @@ -111,6 +111,7 @@ enum {
>> #define IORING_SETUP_R_DISABLED (1U << 6) /* start with ring disabled */
>> #define IORING_SETUP_SUBMIT_ALL (1U << 7) /* continue submit on error */
>> #define IORING_SETUP_SQE128 (1U << 8) /* SQEs are 128b */
>> +#define IORING_SETUP_CQE32 (1U << 9) /* CQEs are 32b */
>>
>> enum {
>> IORING_OP_NOP,
>> @@ -201,6 +202,11 @@ enum {
>> #define IORING_POLL_UPDATE_EVENTS (1U << 1)
>> #define IORING_POLL_UPDATE_USER_DATA (1U << 2)
>>
>> +struct io_uring_cqe_extra {
>> + __u64 extra1;
>> + __u64 extra2;
>> +};
>> +
>> /*
>> * IO completion data structure (Completion Queue Entry)
>> */
>> @@ -208,6 +214,12 @@ struct io_uring_cqe {
>> __u64 user_data; /* sqe->data submission passed back */
>> __s32 res; /* result code for this event */
>> __u32 flags;
>> +
>> + /*
>> + * If the ring is initialized with IORING_SETUP_CQE32, then this field
>> + * contains 16-bytes of padding, doubling the size of the CQE.
>> + */
>> + struct io_uring_cqe_extra b[0];
>> };
>Will it be any better to replace struct b[0] with "u64 extra[ ]" ?
>With that new fields will be referred as cqe->extra[0] and cqe->extra[1].
>
>And if we go that route, maybe "aux" sounds better than "extra".
sorry, picked v1 (rather than v2) here. This part in same though.
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2022-04-22 8:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 20:56 [PATCH v1 00/11] add large CQE support for io-uring Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 01/11] io_uring: support CQE32 in io_uring_cqe Stefan Roesch
2022-04-22 1:51 ` Kanchan Joshi
2022-04-22 5:18 ` Kanchan Joshi [this message]
2022-04-22 21:26 ` Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 02/11] io_uring: wire up inline completion path for CQE32 Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 03/11] io_uring: change ring size calculation " Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 04/11] io_uring: add CQE32 setup processing Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 05/11] io_uring: add CQE32 completion processing Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 06/11] io_uring: modify io_get_cqe for CQE32 Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 07/11] io_uring: flush completions " Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 08/11] io_uring: overflow processing " Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 09/11] io_uring: add tracing for additional CQE32 fields Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 10/11] io_uring: enable CQE32 Stefan Roesch
2022-04-19 20:56 ` [PATCH v1 11/11] io_uring: support CQE32 for nop operation Stefan Roesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220422051827.GC14949@test-zns \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox