From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A70BBC433EF for ; Sat, 23 Apr 2022 17:49:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236725AbiDWRwy (ORCPT ); Sat, 23 Apr 2022 13:52:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236681AbiDWRwt (ORCPT ); Sat, 23 Apr 2022 13:52:49 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91D7A1C82E5 for ; Sat, 23 Apr 2022 10:49:51 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 8631A68D05; Sat, 23 Apr 2022 19:49:48 +0200 (CEST) Date: Sat, 23 Apr 2022 19:49:48 +0200 From: Christoph Hellwig To: Kanchan Joshi Cc: axboe@kernel.dk, io-uring@vger.kernel.org, hch@lst.de Subject: Re: [PATCH] io_uring: cleanup error-handling around io_req_complete Message-ID: <20220423174948.GB29219@lst.de> References: <20220422101048.419942-1-joshi.k@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220422101048.419942-1-joshi.k@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Fri, Apr 22, 2022 at 03:40:48PM +0530, Kanchan Joshi wrote: > Move common error-handling to io_req_complete, so that various callers > avoid repeating that. Few callers (io_tee, io_splice) require slightly > different handling. These are changed to use __io_req_complete instead. > > Suggested-by: Christoph Hellwig > Signed-off-by: Kanchan Joshi Looks good: Reviewed-by: Christoph Hellwig