On Fri, Apr 22, 2022 at 02:27:01PM -0700, Stefan Roesch wrote:
>
>
>On 4/21/22 7:15 PM, Kanchan Joshi wrote:
>> On Thu, Apr 21, 2022 at 1:37 PM Stefan Roesch <shr@fb.com> wrote:
<snip>
>>>  static bool io_cqring_event_overflow(struct io_ring_ctx *ctx, u64 user_data,
>>> -                                    s32 res, u32 cflags)
>>> +                                    s32 res, u32 cflags, u64 extra1, u64 extra2)
>>>  {
>>>         struct io_overflow_cqe *ocqe;
>>> +       size_t ocq_size = sizeof(struct io_overflow_cqe);
>>>
>>> -       ocqe = kmalloc(sizeof(*ocqe), GFP_ATOMIC | __GFP_ACCOUNT);
>>> +       if (ctx->flags & IORING_SETUP_CQE32)
>>
>> This can go inside in a bool variable, as this check is repeated in
>> this function.
>
>V3 will have this change.
While you are at it, good to have this changed in patch 10 too.