From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EEF7C433F5 for ; Tue, 26 Apr 2022 18:22:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236154AbiDZSZk (ORCPT ); Tue, 26 Apr 2022 14:25:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232625AbiDZSZk (ORCPT ); Tue, 26 Apr 2022 14:25:40 -0400 Received: from mx0a-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CEED37BEA for ; Tue, 26 Apr 2022 11:22:31 -0700 (PDT) Received: from pps.filterd (m0001303.ppops.net [127.0.0.1]) by m0001303.ppops.net (8.17.1.5/8.17.1.5) with ESMTP id 23QGQSgU018712 for ; Tue, 26 Apr 2022 11:22:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=facebook; bh=MA3A0dbnlIoOoxWvR5oNNmPs0caRng0kRxqtMVjuGBg=; b=AKDMEriq605l4xBqy/seQT+mNxC9v1r1bGTQ306180tSptK2P2T8pTYY3NE5wx9xwqYg 51IIoOVSZRqBR9fvWakfqo9h/Nu+ehKQkkQC5tWLl5DJf8NEE/9SEPdqPcZVkZGb2whY YfCA4EB+wDlCAVAnBiOKNTgu5r+bImcvdvY= Received: from mail.thefacebook.com ([163.114.132.120]) by m0001303.ppops.net (PPS) with ESMTPS id 3fmd4rv7n5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 26 Apr 2022 11:22:30 -0700 Received: from snc-exhub201.TheFacebook.com (2620:10d:c085:21d::7) by snc-exhub202.TheFacebook.com (2620:10d:c085:21d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 26 Apr 2022 11:22:29 -0700 Received: from twshared13345.18.frc3.facebook.com (2620:10d:c085:208::f) by mail.thefacebook.com (2620:10d:c085:21d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 26 Apr 2022 11:21:39 -0700 Received: by devvm225.atn0.facebook.com (Postfix, from userid 425415) id 42936E2E568C; Tue, 26 Apr 2022 11:21:36 -0700 (PDT) From: Stefan Roesch To: , , CC: , Subject: [PATCH v4 00/12] add large CQE support for io-uring Date: Tue, 26 Apr 2022 11:21:22 -0700 Message-ID: <20220426182134.136504-1-shr@fb.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-ORIG-GUID: cNbp_9MZw4dCgQIM4TZ0yQwW7WUV0ygf X-Proofpoint-GUID: cNbp_9MZw4dCgQIM4TZ0yQwW7WUV0ygf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-26_05,2022-04-26_02,2022-02-23_01 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org This adds the large CQE support for io-uring. Large CQE's are 16 bytes lo= nger. To support the longer CQE's the allocation part is changed and when the C= QE is accessed. The allocation of the large CQE's is twice as big, so the allocation size= is doubled. The ring size calculation needs to take this into account. All accesses to the large CQE's need to be shifted by 1 to take the bigge= r size of each CQE into account. The existing index manipulation does not need t= o be changed and can stay the same. The setup and the completion processing needs to take the new fields into account and initialize them. For the completion processing these fields n= eed to be passed through. The flush completion processing needs to fill the additional CQE32 fields= . The code for overflows needs to be adapted accordingly: the allocation ne= eds to take large CQE's into account. This means that the order of the fields in= the io overflow structure needs to be changed and the allocation needs to be enl= arged for big CQE's. In addition the two new fields need to be copied for large CQE's. The new fields are added to the tracing statements, so the extra1 and ext= ra2 fields are exposed in tracing. The new fields are also exposed in the /pr= oc filesystem entry. For testing purposes the extra1 and extra2 fields are used by the nop ope= ration. Testing: The exisiting tests have been run with the following configurations and t= hey all pass: - Default config - Large SQE - Large CQE - Large SQE and large CQE. In addition a new test has been added to liburing to verify that extra1 a= nd extra2 are set as expected for the nop operation. Note: To use this patch also the corresponding changes to the client library liburing are required. A different patch series is sent out for this. Changes: V2: - added support for CQE32 in the /proc filesystem entry output func= tion - the definition of the io_uring_cqe_extra field has been changed to avoid warning with the /proc changes. V3: - use __64 for big cqe in io_uring_cqe data structure - use io_req_complete_state helper in __io_req_complete32 - support cached cqe's - use bool for cqe32 check in io_cqring_event_overflow - use bool for cqe32 check in __io_uring_show_fdinfo V4: - Rewording of 2 commit messages Stefan Roesch (12): io_uring: support CQE32 in io_uring_cqe io_uring: store add. return values for CQE32 io_uring: change ring size calculation for CQE32 io_uring: add CQE32 setup processing io_uring: add CQE32 completion processing io_uring: modify io_get_cqe for CQE32 io_uring: flush completions for CQE32 io_uring: overflow processing for CQE32 io_uring: add tracing for additional CQE32 fields io_uring: support CQE32 in /proc info io_uring: enable CQE32 io_uring: support CQE32 for nop operation fs/io_uring.c | 234 ++++++++++++++++++++++++++++---- include/trace/events/io_uring.h | 18 ++- include/uapi/linux/io_uring.h | 7 + 3 files changed, 225 insertions(+), 34 deletions(-) base-commit: fd1cf8f1947eb7b009eb79807ec8af0e920fc57b --=20 2.30.2