From: Jens Axboe <[email protected]>
To: [email protected]
Cc: Jens Axboe <[email protected]>
Subject: [PATCH 03/11] io_uring: kill io_rw_buffer_select() wrapper
Date: Fri, 29 Apr 2022 11:56:27 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
After the recent changes, this is direct call to io_buffer_select()
anyway. With this change, there are no wrappers left for provided
buffer selection.
Signed-off-by: Jens Axboe <[email protected]>
---
fs/io_uring.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index 19dfa974ebcf..cdb23f9861c5 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -3599,12 +3599,6 @@ static void __user *io_buffer_select(struct io_kiocb *req, size_t *len,
return ERR_PTR(-ENOBUFS);
}
-static void __user *io_rw_buffer_select(struct io_kiocb *req, size_t *len,
- unsigned int issue_flags)
-{
- return io_buffer_select(req, len, req->buf_index, issue_flags);
-}
-
#ifdef CONFIG_COMPAT
static ssize_t io_compat_import(struct io_kiocb *req, struct iovec *iov,
unsigned int issue_flags)
@@ -3612,7 +3606,7 @@ static ssize_t io_compat_import(struct io_kiocb *req, struct iovec *iov,
struct compat_iovec __user *uiov;
compat_ssize_t clen;
void __user *buf;
- ssize_t len;
+ size_t len;
uiov = u64_to_user_ptr(req->rw.addr);
if (!access_ok(uiov, sizeof(*uiov)))
@@ -3623,7 +3617,7 @@ static ssize_t io_compat_import(struct io_kiocb *req, struct iovec *iov,
return -EINVAL;
len = clen;
- buf = io_rw_buffer_select(req, &len, issue_flags);
+ buf = io_buffer_select(req, &len, req->buf_index, issue_flags);
if (IS_ERR(buf))
return PTR_ERR(buf);
iov[0].iov_base = buf;
@@ -3645,7 +3639,7 @@ static ssize_t __io_iov_buffer_select(struct io_kiocb *req, struct iovec *iov,
len = iov[0].iov_len;
if (len < 0)
return -EINVAL;
- buf = io_rw_buffer_select(req, &len, issue_flags);
+ buf = io_buffer_select(req, &len, req->buf_index, issue_flags);
if (IS_ERR(buf))
return PTR_ERR(buf);
iov[0].iov_base = buf;
@@ -3701,7 +3695,8 @@ static struct iovec *__io_import_iovec(int rw, struct io_kiocb *req,
if (opcode == IORING_OP_READ || opcode == IORING_OP_WRITE) {
if (req->flags & REQ_F_BUFFER_SELECT) {
- buf = io_rw_buffer_select(req, &sqe_len, issue_flags);
+ buf = io_buffer_select(req, &sqe_len, req->buf_index,
+ issue_flags);
if (IS_ERR(buf))
return ERR_CAST(buf);
req->rw.len = sqe_len;
--
2.35.1
next prev parent reply other threads:[~2022-04-29 17:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 17:56 [PATCHSET v2 RFC 0/11] Add support for ring mapped provided buffers Jens Axboe
2022-04-29 17:56 ` [PATCH 01/11] io_uring: kill io_recv_buffer_select() wrapper Jens Axboe
2022-04-29 17:56 ` [PATCH 02/11] io_uring: make io_buffer_select() return the user address directly Jens Axboe
2022-04-29 17:56 ` Jens Axboe [this message]
2022-04-29 17:56 ` [PATCH 04/11] io_uring: ignore ->buf_index if REQ_F_BUFFER_SELECT isn't set Jens Axboe
2022-04-29 17:56 ` [PATCH 05/11] io_uring: always use req->buf_index for the provided buffer group Jens Axboe
2022-04-29 17:56 ` [PATCH 06/11] io_uring: cache last io_buffer_list lookup Jens Axboe
2022-04-29 17:56 ` [PATCH 07/11] io_uring: add buffer selection support to IORING_OP_NOP Jens Axboe
2022-04-29 17:56 ` [PATCH 08/11] io_uring: add io_pin_pages() helper Jens Axboe
2022-04-29 17:56 ` [PATCH 09/11] io_uring: abstract out provided buffer list selection Jens Axboe
2022-04-29 17:56 ` [PATCH 10/11] io_uring: relocate io_buffer_get_list() Jens Axboe
2022-04-29 17:56 ` [PATCH 11/11] io_uring: add support for ring mapped supplied buffers Jens Axboe
2022-05-01 13:14 ` [PATCHSET v2 RFC 0/11] Add support for ring mapped provided buffers Pavel Begunkov
2022-05-01 13:28 ` Jens Axboe
2022-05-01 13:39 ` Pavel Begunkov
2022-05-01 14:25 ` Jens Axboe
2022-05-01 15:00 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox