From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5313C433F5 for ; Tue, 3 May 2022 20:56:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235345AbiECVAJ (ORCPT ); Tue, 3 May 2022 17:00:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231552AbiECVAI (ORCPT ); Tue, 3 May 2022 17:00:08 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B83401EC7B for ; Tue, 3 May 2022 13:56:34 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 65DE968B05; Tue, 3 May 2022 22:56:31 +0200 (CEST) Date: Tue, 3 May 2022 22:56:31 +0200 From: Christoph Hellwig To: Pankaj Raghav Cc: axboe@kernel.dk, hch@lst.de, io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, asml.silence@gmail.com, ming.lei@redhat.com, mcgrof@kernel.org, shr@fb.com, joshiiitr@gmail.com, gost.dev@samsung.com, Anuj Gupta , Kanchan Joshi Subject: Re: [PATCH v3 5/5] nvme: add vectored-io support for uring-cmd Message-ID: <20220503205631.GD9567@lst.de> References: <20220503184831.78705-1-p.raghav@samsung.com> <20220503184831.78705-6-p.raghav@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220503184831.78705-6-p.raghav@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org > + union { > + __u32 data_len; /* for non-vectored io */ > + __u32 vec_cnt; /* for vectored io */ > + }; Nothing ever uses vec_cnt, so I don't think there is any point in adding this union. The rest looks good to me: Reviewed-by: Christoph Hellwig