From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5969AC433FE for ; Thu, 5 May 2022 13:30:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379519AbiEENeM (ORCPT ); Thu, 5 May 2022 09:34:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243197AbiEENeK (ORCPT ); Thu, 5 May 2022 09:34:10 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB3FB5FB3 for ; Thu, 5 May 2022 06:30:30 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 6BE0568AA6; Thu, 5 May 2022 15:30:27 +0200 (CEST) Date: Thu, 5 May 2022 15:30:26 +0200 From: Christoph Hellwig To: Kanchan Joshi Cc: axboe@kernel.dk, hch@lst.de, io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, asml.silence@gmail.com, ming.lei@redhat.com, mcgrof@kernel.org, shr@fb.com, joshiiitr@gmail.com, anuj20.g@samsung.com, gost.dev@samsung.com Subject: Re: [PATCH v4 3/5] nvme: refactor nvme_submit_user_cmd() Message-ID: <20220505133026.GB11853@lst.de> References: <20220505060616.803816-1-joshi.k@samsung.com> <20220505060616.803816-4-joshi.k@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220505060616.803816-4-joshi.k@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Thu, May 05, 2022 at 11:36:14AM +0530, Kanchan Joshi wrote: > +{ > + struct bio_integrity_payload *bip = bio_integrity(bio); > + > + return bip ? bvec_virt(bip->bip_vec) : NULL; > +} Nit, I'd prefer this as the slightly more verbose: if (!bip) return NULL; return bvec_virt(bip->bip_vec);