From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1B47C433FE for ; Mon, 9 May 2022 06:09:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229966AbiEIGLl (ORCPT ); Mon, 9 May 2022 02:11:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235347AbiEIGEj (ORCPT ); Mon, 9 May 2022 02:04:39 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B85CE8073E for ; Sun, 8 May 2022 23:00:45 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 60DD968AFE; Mon, 9 May 2022 08:00:11 +0200 (CEST) Date: Mon, 9 May 2022 08:00:10 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Kanchan Joshi , io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, asml.silence@gmail.com, ming.lei@redhat.com, mcgrof@kernel.org, shr@fb.com, joshiiitr@gmail.com, anuj20.g@samsung.com, gost.dev@samsung.com Subject: Re: [PATCH v4 4/5] nvme: wire-up uring-cmd support for io-passthru on char-device. Message-ID: <20220509060010.GA16939@lst.de> References: <20220505134256.GA13109@lst.de> <8ae2c507-ffcc-b693-336d-2d9f907edb76@kernel.dk> <20220506082844.GA30405@lst.de> <6b0811df-e2a4-22fc-7615-44e5615ce6a4@kernel.dk> <20220506145058.GA24077@lst.de> <45b5f76b-b186-e0b9-7b24-e048f73942d5@kernel.dk> <20220507050317.GA27706@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Sat, May 07, 2022 at 06:53:30AM -0600, Jens Axboe wrote: > How about we just add a comment? We use it in two spots, but one has > knowledge of the sqe64 vs sqe128 state, the other one does not. Hence > not sure how best to add a helper for this. One also must be a compile > time constant. Best I can think of is the below. Not the prettiest, but > it does keep it in one spot and with a single comment rather than in two > spots. If you think just a comment is better I can live with that, also the proposed macro also looks fine to me.