From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B99CC4332F for ; Mon, 9 May 2022 23:24:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232406AbiEIX20 (ORCPT ); Mon, 9 May 2022 19:28:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231776AbiEIX2Z (ORCPT ); Mon, 9 May 2022 19:28:25 -0400 Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E525F16C5F5; Mon, 9 May 2022 16:24:29 -0700 (PDT) Received: from dread.disaster.area (pa49-181-2-147.pa.nsw.optusnet.com.au [49.181.2.147]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 457145345E2; Tue, 10 May 2022 09:24:27 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1noCjp-00A4n4-1M; Tue, 10 May 2022 09:24:25 +1000 Date: Tue, 10 May 2022 09:24:25 +1000 From: Dave Chinner To: Stefan Roesch Cc: io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC PATCH v1 11/18] xfs: add async buffered write support Message-ID: <20220509232425.GQ1098723@dread.disaster.area> References: <20220426174335.4004987-1-shr@fb.com> <20220426174335.4004987-12-shr@fb.com> <20220426225652.GS1544202@dread.disaster.area> <30f2920c-5262-7cb0-05b5-6e84a76162a7@fb.com> <20220428215442.GW1098723@dread.disaster.area> <19d411e5-fe1f-a3f8-36e0-87284a1c02f3@fb.com> <20220506092915.GI1098723@dread.disaster.area> <31f09969-2277-6692-b204-f884dc65348f@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <31f09969-2277-6692-b204-f884dc65348f@fb.com> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.4 cv=VuxAv86n c=1 sm=1 tr=0 ts=6279a2ab a=ivVLWpVy4j68lT4lJFbQgw==:117 a=ivVLWpVy4j68lT4lJFbQgw==:17 a=kj9zAlcOel0A:10 a=oZkIemNP1mAA:10 a=7-415B0cAAAA:8 a=l3-sH5QmxRaIQiL6LJgA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Mon, May 09, 2022 at 12:32:59PM -0700, Stefan Roesch wrote: > On 5/6/22 2:29 AM, Dave Chinner wrote: > > On Mon, May 02, 2022 at 02:21:17PM -0700, Stefan Roesch wrote: > >> On 4/28/22 2:54 PM, Dave Chinner wrote: > >>> On Thu, Apr 28, 2022 at 12:58:59PM -0700, Stefan Roesch wrote: > >> - replace the pointer to iocb with pointer to xfs_inode in the function xfs_ilock_iocb() > >> and also pass in the flags value as a parameter. > >> or > >> - create function xfs_ilock_inode(), which xfs_ilock_iocb() calls. The existing > >> calls will not need to change, only the xfs_ilock in xfs_file_buffered_write() > >> will use xfs_ilock_inode(). > > > > You're making this way more complex than it needs to be. As I said: > > > >>> Regardless, if this is a problem, then just pass the XFS inode to > >>> xfs_ilock_iocb() and this is a moot point. > > > > The function xfs_ilock_iocb() is expecting a pointer to the data structure kiocb, not > a pointer to xfs_inode. I don't see how that's possible without changing the signature > of xfs_ilock_iocb(). For the *third time*: pass the xfs_inode to xfs_ilock_iocb() and update all the callers to do the same thing. -Dave. -- Dave Chinner david@fromorbit.com