From: Hao Xu <[email protected]>
To: [email protected]
Cc: Jens Axboe <[email protected]>, Pavel Begunkov <[email protected]>
Subject: [PATCH 11/11] io_uring: cancel works in exec work list for fixed worker
Date: Sun, 15 May 2022 21:12:30 +0800 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
From: Hao Xu <[email protected]>
From: Hao Xu <[email protected]>
When users want to cancel a request, look into the exec work list of
fixed worker as well. It's not sane to ignore it.
Signed-off-by: Hao Xu <[email protected]>
---
fs/io-wq.c | 46 ++++++++++++++++++++++++++++++----------------
1 file changed, 30 insertions(+), 16 deletions(-)
diff --git a/fs/io-wq.c b/fs/io-wq.c
index c6e4179a9961..5345a5f57e4f 100644
--- a/fs/io-wq.c
+++ b/fs/io-wq.c
@@ -1287,32 +1287,26 @@ static bool io_acct_cancel_pending_work(struct io_wqe *wqe,
return false;
}
-static void io_wqe_cancel_pending_work(struct io_wqe *wqe,
- struct io_cb_cancel_data *match)
-{
+static void io_wqe_cancel_pending_work_fixed(struct io_wqe *wqe,
+ struct io_cb_cancel_data *match,
+ bool exec) {
int i, j;
struct io_wqe_acct *acct, *iw_acct;
-retry_public:
- for (i = 0; i < IO_WQ_ACCT_NR; i++) {
- acct = io_get_acct(wqe, i == 0, false);
- if (io_acct_cancel_pending_work(wqe, acct, match)) {
- if (match->cancel_all)
- goto retry_public;
- return;
- }
- }
-
-retry_private:
+retry:
for (i = 0; i < IO_WQ_ACCT_NR; i++) {
acct = io_get_acct(wqe, i == 0, true);
raw_spin_lock(&acct->lock);
for (j = 0; j < acct->nr_fixed; j++) {
- iw_acct = &acct->fixed_workers[j]->acct;
+ if (exec)
+ iw_acct = &acct->fixed_workers[j]->acct;
+ else
+ iw_acct = &acct->fixed_workers[j]->exec_acct;
+
if (io_acct_cancel_pending_work(wqe, iw_acct, match)) {
if (match->cancel_all) {
raw_spin_unlock(&acct->lock);
- goto retry_private;
+ goto retry;
}
break;
}
@@ -1321,6 +1315,26 @@ static void io_wqe_cancel_pending_work(struct io_wqe *wqe,
}
}
+static void io_wqe_cancel_pending_work(struct io_wqe *wqe,
+ struct io_cb_cancel_data *match)
+{
+ int i;
+ struct io_wqe_acct *acct;
+
+retry:
+ for (i = 0; i < IO_WQ_ACCT_NR; i++) {
+ acct = io_get_acct(wqe, i == 0, false);
+ if (io_acct_cancel_pending_work(wqe, acct, match)) {
+ if (match->cancel_all)
+ goto retry;
+ return;
+ }
+ }
+
+ io_wqe_cancel_pending_work_fixed(wqe, match, false);
+ io_wqe_cancel_pending_work_fixed(wqe, match, true);
+}
+
static void io_wqe_cancel_running_work(struct io_wqe *wqe,
struct io_cb_cancel_data *match)
{
--
2.25.1
next prev parent reply other threads:[~2022-05-15 13:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-15 13:12 [PATCH v4 00/11] fixed worker Hao Xu
2022-05-15 13:12 ` [PATCH 01/11] io-wq: add a worker flag for individual exit Hao Xu
2022-05-15 13:12 ` [PATCH 02/11] io-wq: change argument of create_io_worker() for convienence Hao Xu
2022-05-15 13:12 ` [PATCH 03/11] io-wq: add infra data structure for fixed workers Hao Xu
2022-05-15 13:12 ` [PATCH 04/11] io-wq: tweak io_get_acct() Hao Xu
2022-05-15 13:12 ` [PATCH 05/11] io-wq: fixed worker initialization Hao Xu
2022-05-15 13:12 ` [PATCH 06/11] io-wq: fixed worker exit Hao Xu
2022-05-15 13:12 ` [PATCH 07/11] io-wq: implement fixed worker logic Hao Xu
2022-05-15 13:12 ` [PATCH 08/11] io-wq: batch the handling of fixed worker private works Hao Xu
2022-05-15 13:12 ` [PATCH 09/11] io_uring: add register fixed worker interface Hao Xu
2022-05-15 13:12 ` [PATCH 10/11] io-wq: add an work list for fixed worker Hao Xu
2022-05-15 13:12 ` Hao Xu [this message]
2022-05-31 7:05 ` [PATCH v4 00/11] " Hao Xu
2022-05-31 8:46 ` Jens Axboe
2022-05-31 8:55 ` Hao Xu
2022-05-31 9:02 ` Jens Axboe
2022-05-31 9:09 ` Hao Xu
-- strict thread matches above, loose matches on Subject: below --
2022-06-27 13:35 [PATCH v5 " Hao Xu
2022-06-27 13:35 ` [PATCH 11/11] io_uring: cancel works in exec work list for " Hao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox