From: Stefan Roesch <[email protected]>
To: <[email protected]>, <[email protected]>,
<[email protected]>, <[email protected]>,
<[email protected]>
Cc: <[email protected]>, <[email protected]>, <[email protected]>, <[email protected]>
Subject: [PATCH v5 12/16] io_uring: Add tracepoint for short writes
Date: Wed, 25 May 2022 15:34:28 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
This adds the io_uring_short_write tracepoint to io_uring. A short write
is issued if not all pages that are required for a write are in the page
cache and the async buffered writes have to return EAGAIN.
Signed-off-by: Stefan Roesch <[email protected]>
---
fs/io_uring.c | 3 +++
include/trace/events/io_uring.h | 25 +++++++++++++++++++++++++
2 files changed, 28 insertions(+)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index c0771e215669..9ab68138f442 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -4543,6 +4543,9 @@ static int io_write(struct io_kiocb *req, unsigned int issue_flags)
if (ret2 != req->cqe.res && ret2 >= 0 && need_complete_io(req)) {
struct io_async_rw *rw;
+ trace_io_uring_short_write(req->ctx, kiocb->ki_pos - ret2,
+ req->cqe.res, ret2);
+
/* This is a partial write. The file pos has already been
* updated, setup the async struct to complete the request
* in the worker. Also update bytes_done to account for
diff --git a/include/trace/events/io_uring.h b/include/trace/events/io_uring.h
index 66fcc5a1a5b1..25df513660cc 100644
--- a/include/trace/events/io_uring.h
+++ b/include/trace/events/io_uring.h
@@ -600,6 +600,31 @@ TRACE_EVENT(io_uring_cqe_overflow,
__entry->cflags, __entry->ocqe)
);
+TRACE_EVENT(io_uring_short_write,
+
+ TP_PROTO(void *ctx, u64 fpos, u64 wanted, u64 got),
+
+ TP_ARGS(ctx, fpos, wanted, got),
+
+ TP_STRUCT__entry(
+ __field(void *, ctx)
+ __field(u64, fpos)
+ __field(u64, wanted)
+ __field(u64, got)
+ ),
+
+ TP_fast_assign(
+ __entry->ctx = ctx;
+ __entry->fpos = fpos;
+ __entry->wanted = wanted;
+ __entry->got = got;
+ ),
+
+ TP_printk("ring %p, fpos %lld, wanted %lld, got %lld",
+ __entry->ctx, __entry->fpos,
+ __entry->wanted, __entry->got)
+);
+
#endif /* _TRACE_IO_URING_H */
/* This part must be outside protection */
--
2.30.2
next prev parent reply other threads:[~2022-05-25 22:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 22:34 [PATCH v5 00/16] io-uring/xfs: support async buffered writes Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 01/16] mm: Move starting of background writeback into the main balancing loop Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 02/16] mm: Move updates of dirty_exceeded into one place Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 03/16] mm: Add balance_dirty_pages_ratelimited_flags() function Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 04/16] iomap: Add flags parameter to iomap_page_create() Stefan Roesch
2022-05-26 13:43 ` Jan Kara
2022-05-26 17:39 ` Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 05/16] iomap: Add async buffered write support Stefan Roesch
2022-05-26 13:39 ` Jan Kara
2022-05-25 22:34 ` [PATCH v5 06/16] fs: Add check for async buffered writes to generic_write_checks Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 07/16] fs: add __remove_file_privs() with flags parameter Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 08/16] fs: Split off inode_needs_update_time and __file_update_time Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 09/16] fs: Add async write file modification handling Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 10/16] fs: Optimization for concurrent file time updates Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 11/16] io_uring: Add support for async buffered writes Stefan Roesch
2022-05-25 22:34 ` Stefan Roesch [this message]
2022-05-25 22:34 ` [PATCH v5 13/16] xfs: Specify lockmode when calling xfs_ilock_for_iomap() Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 14/16] xfs: Change function signature of xfs_ilock_iocb() Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 15/16] xfs: Add async buffered write support Stefan Roesch
2022-05-25 22:34 ` [PATCH v5 16/16] xfs: Enable " Stefan Roesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox