From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <io-uring-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
by smtp.lore.kernel.org (Postfix) with ESMTP id 1BCA2C433FE
for <io-uring@archiver.kernel.org>; Thu, 26 May 2022 17:39:39 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S1348345AbiEZRjf (ORCPT <rfc822;io-uring@archiver.kernel.org>);
Thu, 26 May 2022 13:39:35 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59918 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S1348349AbiEZRjZ (ORCPT
<rfc822;io-uring@vger.kernel.org>); Thu, 26 May 2022 13:39:25 -0400
Received: from mx0a-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B06F89CF35
for <io-uring@vger.kernel.org>; Thu, 26 May 2022 10:39:19 -0700 (PDT)
Received: from pps.filterd (m0001303.ppops.net [127.0.0.1])
by m0001303.ppops.net (8.17.1.5/8.17.1.5) with ESMTP id 24QGJXBH012005
for <io-uring@vger.kernel.org>; Thu, 26 May 2022 10:39:18 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject
: date : message-id : in-reply-to : references : mime-version :
content-transfer-encoding : content-type; s=facebook;
bh=/DrIfFwryF28jpgKYd8aC2BVP4/JsBupN+LpZHKHGXE=;
b=nAqMjj79pIHtEkqAzV/rZr1eEQAQCJFsJ/3o9FiEDLrYE90emadUdWEedrOn8f8Y3FJj
YFv59h/uDn9xK5L16Qrf9Dxqsc2Q+aa71PwKsAtK9D0mAL9rKHYeMJhPfSK7xjZBjh96
uX6CYeKB0kB2eBVq8ANWvsm0NV8WHCLwu94=
Received: from mail.thefacebook.com ([163.114.132.120])
by m0001303.ppops.net (PPS) with ESMTPS id 3g9qtug2h9-6
(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT)
for <io-uring@vger.kernel.org>; Thu, 26 May 2022 10:39:18 -0700
Received: from twshared5413.23.frc3.facebook.com (2620:10d:c085:208::f) by
mail.thefacebook.com (2620:10d:c085:21d::4) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2375.28; Thu, 26 May 2022 10:39:17 -0700
Received: by devvm225.atn0.facebook.com (Postfix, from userid 425415)
id A16A5FA621E4; Thu, 26 May 2022 10:38:45 -0700 (PDT)
From: Stefan Roesch <shr@fb.com>
To: <io-uring@vger.kernel.org>, <kernel-team@fb.com>,
<linux-mm@kvack.org>, <linux-xfs@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>
CC: <shr@fb.com>, <david@fromorbit.com>, <jack@suse.cz>,
<hch@infradead.org>
Subject: [PATCH v6 12/16] io_uring: Add tracepoint for short writes
Date: Thu, 26 May 2022 10:38:36 -0700
Message-ID: <20220526173840.578265-13-shr@fb.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220526173840.578265-1-shr@fb.com>
References: <20220526173840.578265-1-shr@fb.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-FB-Internal: Safe
Content-Type: text/plain
X-Proofpoint-GUID: igTflGAiRjo7koZPerzH2-E28eyvyw21
X-Proofpoint-ORIG-GUID: igTflGAiRjo7koZPerzH2-E28eyvyw21
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514
definitions=2022-05-26_09,2022-05-25_02,2022-02-23_01
Precedence: bulk
List-ID: <io-uring.vger.kernel.org>
X-Mailing-List: io-uring@vger.kernel.org
This adds the io_uring_short_write tracepoint to io_uring. A short write
is issued if not all pages that are required for a write are in the page
cache and the async buffered writes have to return EAGAIN.
Signed-off-by: Stefan Roesch <shr@fb.com>
---
fs/io_uring.c | 3 +++
include/trace/events/io_uring.h | 25 +++++++++++++++++++++++++
2 files changed, 28 insertions(+)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index c0771e215669..9ab68138f442 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -4543,6 +4543,9 @@ static int io_write(struct io_kiocb *req, unsigned =
int issue_flags)
if (ret2 !=3D req->cqe.res && ret2 >=3D 0 && need_complete_io(req)) {
struct io_async_rw *rw;
=20
+ trace_io_uring_short_write(req->ctx, kiocb->ki_pos - ret2,
+ req->cqe.res, ret2);
+
/* This is a partial write. The file pos has already been
* updated, setup the async struct to complete the request
* in the worker. Also update bytes_done to account for
diff --git a/include/trace/events/io_uring.h b/include/trace/events/io_ur=
ing.h
index 66fcc5a1a5b1..25df513660cc 100644
--- a/include/trace/events/io_uring.h
+++ b/include/trace/events/io_uring.h
@@ -600,6 +600,31 @@ TRACE_EVENT(io_uring_cqe_overflow,
__entry->cflags, __entry->ocqe)
);
=20
+TRACE_EVENT(io_uring_short_write,
+
+ TP_PROTO(void *ctx, u64 fpos, u64 wanted, u64 got),
+
+ TP_ARGS(ctx, fpos, wanted, got),
+
+ TP_STRUCT__entry(
+ __field(void *, ctx)
+ __field(u64, fpos)
+ __field(u64, wanted)
+ __field(u64, got)
+ ),
+
+ TP_fast_assign(
+ __entry->ctx =3D ctx;
+ __entry->fpos =3D fpos;
+ __entry->wanted =3D wanted;
+ __entry->got =3D got;
+ ),
+
+ TP_printk("ring %p, fpos %lld, wanted %lld, got %lld",
+ __entry->ctx, __entry->fpos,
+ __entry->wanted, __entry->got)
+);
+
#endif /* _TRACE_IO_URING_H */
=20
/* This part must be outside protection */
--=20
2.30.2