From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9487CC43334 for ; Tue, 14 Jun 2022 12:01:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231868AbiFNMBX (ORCPT ); Tue, 14 Jun 2022 08:01:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243641AbiFNMBX (ORCPT ); Tue, 14 Jun 2022 08:01:23 -0400 Received: from out1.migadu.com (out1.migadu.com [IPv6:2001:41d0:2:863f::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EC504755C for ; Tue, 14 Jun 2022 05:01:19 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1655208077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dgrct1FxSYsHxO/MwcZ4td4vVsqDcNzHZzALiewi/ds=; b=issoEOlICU+/CjKishgjWMnv4GJ1ZDwOd8zbjoiBc5neNecTpNnvtZT+sT6Lq4zpIdFpqP 7ascNMeOOghwsqFtR1cX2M3vFlhJH2yFVfcAuYsGFtPDiS1Z4mYHMAMWFSUqa9XIsOh5ps EXNedFwBJOOQkXDym1Y+Ay5mbLp5Src= From: Hao Xu To: io-uring@vger.kernel.org Cc: Jens Axboe , Pavel Begunkov Subject: [PATCH 2/2] io_uring: kbuf: add comments for some tricky code Date: Tue, 14 Jun 2022 20:01:08 +0800 Message-Id: <20220614120108.1134773-1-hao.xu@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org From: Hao Xu Add comments to explain why it is always under uring lock when incrementing head in __io_kbuf_recycle. And rectify one comemnt about kbuf consuming in iowq case. Signed-off-by: Hao Xu --- io_uring/kbuf.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/io_uring/kbuf.c b/io_uring/kbuf.c index 9cdbc018fd64..37f06456bf30 100644 --- a/io_uring/kbuf.c +++ b/io_uring/kbuf.c @@ -50,6 +50,13 @@ void __io_kbuf_recycle(struct io_kiocb *req, unsigned issue_flags) if (req->flags & REQ_F_BUFFER_RING) { if (req->buf_list) { if (req->flags & REQ_F_PARTIAL_IO) { + /* + * if we reach here, uring_lock has been + ¦* holden. Because in iowq, we already + ¦* cleared req->buf_list to NULL when got + ¦* the buffer from the ring, which means + ¦* we cannot be here in that case. + */ req->buf_list->head++; req->buf_list = NULL; } else { @@ -128,12 +135,13 @@ static void __user *io_ring_buffer_select(struct io_kiocb *req, size_t *len, if (issue_flags & IO_URING_F_UNLOCKED) { /* * If we came in unlocked, we have no choice but to consume the - * buffer here. This does mean it'll be pinned until the IO - * completes. But coming in unlocked means we're in io-wq - * context, hence there should be no further retry. For the - * locked case, the caller must ensure to call the commit when - * the transfer completes (or if we get -EAGAIN and must poll - * or retry). + * buffer here otherwise nothing ensures the buffer not being + * used by others. This does mean it'll be pinned until the IO + * completes though coming in unlocked means we're in io-wq + * context and there may be further retries in async hybrid mode. + * For the locked case, the caller must ensure to call the commit + * when the transfer completes (or if we get -EAGAIN and must + * poll or retry). */ req->buf_list = NULL; bl->head++; -- 2.25.1