public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH liburing v2 0/8] aarch64 support
@ 2022-06-29 17:58 Ammar Faizi
  2022-06-29 17:58 ` [PATCH liburing v2 1/8] CHANGELOG: Fixup missing space Ammar Faizi
                   ` (8 more replies)
  0 siblings, 9 replies; 12+ messages in thread
From: Ammar Faizi @ 2022-06-29 17:58 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Ammar Faizi, Alviro Iskandar Setiawan, Fernanda Ma'rouf,
	Pavel Begunkov, Hao Xu, io-uring Mailing List,
	GNU/Weeb Mailing List

From: Ammar Faizi <[email protected]>

Hi Jens,

This is v2 revision of aarch64 support.

This series contains nolibc support for aarch64 and one extra irrelevant
cleanup (patch #1). The missing bit from aarch64 is get_page_size()
which is a bit complicated to implement without libc.

aarch64 supports three values of page size: 4K, 16K, and 64K which are
selected at kernel compilation time. Therefore, we can't hard code the
page size for this arch. In this series we utilize open(), read() and
close() syscall to find the page size from /proc/self/auxv.

The auxiliary vector contains information about the page size, it is
located at `AT_PAGESZ` keyval pair.

For more details about the auxv data structure, check the link below.

Link: https://github.com/torvalds/linux/blob/v5.19-rc4/fs/binfmt_elf.c#L260
Link: https://lwn.net/Articles/631631/

There are 8 patches in this series. Summary:

- Patch 1 is just a trivial changelog fix.
- Patch 2 and 3 are to add open() and read() syscall. We will need them
  to get the page size on aarch64.
- Patch 4 is to remove __INTERNAL__LIBURING_SYSCALL_H checks.
- Patch 5 is to add get_page_size() function.
- Patch 6 is to enable the nolibc support for aarch64.
- Patch 7 is for GitHub bot build.
- Patch 8 is to update the CHANGELOG to note aarch64 nolibc support.

I have built it with GitHub bot and it compiles just fine. But I don't
have an aarch64 machine to run the tests. Since you are using aarch64,
I can rely on you to test it.

How to test this?

  make clean;
  ./configure --nolibc;
  make -j8;

  ldd src/liburing.so.2.3;
  # Make sure you don't see libc.so from the `ldd` command.

  make runtests;

Please give it a test, thanks!

## Changelog

v1 -> v2:
  - Drop aarch64 renaming directory patch.
  - Fallback the page size to 4K if we fail to get it.
  - Cache the page size after we read it from /proc/self/auxv.
  - Massage commit messages.
  - Note aarch64 nolibc support in CHANGELOG.


Signed-off-by: Ammar Faizi <[email protected]>
---

Ammar Faizi (8):
  CHANGELOG: Fixup missing space
  arch: syscall: Add `__sys_open()` syscall
  arch: syscall: Add `__sys_read()` syscall
  arch: Remove `__INTERNAL__LIBURING_LIB_H` checks
  arch/aarch64: lib: Add `get_page_size()` function
  arch: Enable nolibc support for aarch64
  .github: Enable aarch64 nolibc build for GitHub bot
  CHANGELOG: Note about aarch64 support

 .github/workflows/build.yml |  2 +-
 CHANGELOG                   |  7 +++++-
 src/arch/aarch64/lib.h      | 45 +++++++++++++++++++++++++++++++++++++
 src/arch/aarch64/syscall.h  |  8 +++----
 src/arch/generic/lib.h      |  4 ----
 src/arch/generic/syscall.h  | 20 +++++++++++++----
 src/arch/syscall-defs.h     | 12 ++++++++++
 src/arch/x86/lib.h          |  4 ----
 src/arch/x86/syscall.h      |  4 ----
 src/lib.h                   | 32 +++++++++++++-------------
 src/syscall.h               |  2 --
 11 files changed, 100 insertions(+), 40 deletions(-)
 create mode 100644 src/arch/aarch64/lib.h


base-commit: 7d1cce2112ddf358b56ae0abd18c86e8ede9447f
-- 
Ammar Faizi


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2022-07-04 15:37 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-29 17:58 [PATCH liburing v2 0/8] aarch64 support Ammar Faizi
2022-06-29 17:58 ` [PATCH liburing v2 1/8] CHANGELOG: Fixup missing space Ammar Faizi
2022-06-29 17:58 ` [PATCH liburing v2 2/8] arch: syscall: Add `__sys_open()` syscall Ammar Faizi
2022-06-29 17:58 ` [PATCH liburing v2 3/8] arch: syscall: Add `__sys_read()` syscall Ammar Faizi
2022-06-29 17:58 ` [PATCH liburing v2 4/8] arch: Remove `__INTERNAL__LIBURING_LIB_H` checks Ammar Faizi
2022-06-29 17:58 ` [PATCH liburing v2 5/8] arch/aarch64: lib: Add `get_page_size()` function Ammar Faizi
2022-06-29 17:58 ` [PATCH liburing v2 6/8] arch: Enable nolibc support for aarch64 Ammar Faizi
2022-06-29 17:58 ` [PATCH liburing v2 7/8] .github: Enable aarch64 nolibc build for GitHub bot Ammar Faizi
2022-06-29 17:58 ` [PATCH liburing v2 8/8] CHANGELOG: Note about aarch64 support Ammar Faizi
2022-07-04 12:52 ` [PATCH liburing v2 0/8] " Ammar Faizi
2022-07-04 13:05   ` Jens Axboe
2022-07-04 15:36     ` Ammar Faizi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox