From: Eli Schwartz <[email protected]>
To: [email protected]
Subject: [PATCH liburing 1/6] tests: do not report an error message when return ret that might be a skip
Date: Tue, 5 Jul 2022 23:40:53 -0400 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
We are going to update these functions to distinguish between pass/skip,
so ret might be nonzero but have handled its own non-error message.
Signed-off-by: Eli Schwartz <[email protected]>
---
test/fallocate.c | 8 ++++++--
test/file-update.c | 4 +++-
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/test/fallocate.c b/test/fallocate.c
index 6cb57e0..a9bf6fd 100644
--- a/test/fallocate.c
+++ b/test/fallocate.c
@@ -230,7 +230,9 @@ int main(int argc, char *argv[])
ret = test_fallocate(&ring);
if (ret) {
- fprintf(stderr, "test_fallocate failed\n");
+ if (ret != T_EXIT_SKIP) {
+ fprintf(stderr, "test_fallocate failed\n");
+ }
return ret;
}
@@ -242,7 +244,9 @@ int main(int argc, char *argv[])
ret = test_fallocate_rlimit(&ring);
if (ret) {
- fprintf(stderr, "test_fallocate_rlimit failed\n");
+ if (ret != T_EXIT_SKIP) {
+ fprintf(stderr, "test_fallocate_rlimit failed\n");
+ }
return ret;
}
diff --git a/test/file-update.c b/test/file-update.c
index 97db95a..b8039c9 100644
--- a/test/file-update.c
+++ b/test/file-update.c
@@ -165,7 +165,9 @@ int main(int argc, char *argv[])
ret = test_sqe_update(&r1);
if (ret) {
- fprintf(stderr, "test_sqe_update failed\n");
+ if (ret != T_EXIT_SKIP) {
+ fprintf(stderr, "test_sqe_update failed\n");
+ }
return ret;
}
--
2.35.1
next prev parent reply other threads:[~2022-07-06 3:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 3:40 [PATCH liburing 0/6] More wor on updating exit codes to use Eli Schwartz
2022-07-06 3:40 ` Eli Schwartz [this message]
2022-07-06 3:40 ` [PATCH liburing 2/6] tests: handle some skips that used a goto to enter cleanup Eli Schwartz
2022-07-06 3:40 ` [PATCH liburing 3/6] tests: more work on updating exit codes to use enum-based status reporting Eli Schwartz
2022-07-06 3:40 ` [PATCH liburing 4/6] tests: mention in a status message that this is a skip Eli Schwartz
2022-07-06 3:40 ` [PATCH liburing 5/6] tests: migrate a skip that used a goto to enter cleanup Eli Schwartz
2022-07-06 3:40 ` [PATCH liburing 6/6] tests: correctly exit with failure in a looped test Eli Schwartz
2022-07-06 12:45 ` [PATCH liburing 0/6] More wor on updating exit codes to use Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox