From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD7B3C43334 for ; Thu, 14 Jul 2022 11:03:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230002AbiGNLDO (ORCPT ); Thu, 14 Jul 2022 07:03:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237823AbiGNLDN (ORCPT ); Thu, 14 Jul 2022 07:03:13 -0400 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14A3F5720E for ; Thu, 14 Jul 2022 04:03:12 -0700 (PDT) Received: from pps.filterd (m0148461.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26E6xBH7003506 for ; Thu, 14 Jul 2022 04:03:11 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=facebook; bh=8RKmEMumnUvZdCtvdU09M/kYrREzaq06s/h2ae1JAdA=; b=NP1/fbWlNHPhyU945AL0PCdB3PFn3ZS5wEdDcZWMU1fT9gvfQRW1k450Zc4hLU+zzLEy w3ntrbvLzPuqUsabf8yByXNb54WviI1FDqPo6h9QGWvw9m18s6WQTHKbysOfVeLikNuW rXZRHIlV3LbCdq+6AYzGESksg/hCQkS4ICw= Received: from maileast.thefacebook.com ([163.114.130.16]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3h9h5ca7ht-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 14 Jul 2022 04:03:11 -0700 Received: from twshared18317.08.ash9.facebook.com (2620:10d:c0a8:1b::d) by mail.thefacebook.com (2620:10d:c0a8:83::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 14 Jul 2022 04:03:09 -0700 Received: by devbig038.lla2.facebook.com (Postfix, from userid 572232) id E85862FCA611; Thu, 14 Jul 2022 04:03:01 -0700 (PDT) From: Dylan Yudaken To: Jens Axboe , Pavel Begunkov , , , , , CC: , , Dylan Yudaken Subject: [PATCH v3 for-next 0/3] io_uring: multishot recvmsg Date: Thu, 14 Jul 2022 04:02:55 -0700 Message-ID: <20220714110258.1336200-1-dylany@fb.com> X-Mailer: git-send-email 2.30.2 X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-GUID: oH9751Jlw-0vOlgciK7vmnyFZsfRPFZv X-Proofpoint-ORIG-GUID: oH9751Jlw-0vOlgciK7vmnyFZsfRPFZv Content-Transfer-Encoding: quoted-printable X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-14_08,2022-07-14_01,2022-06-22_01 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org This series adds multishot support to recvmsg in io_uring. The idea is that you submit a single multishot recvmsg and then receive completions as and when data arrives. For recvmsg each completion also has control data, and this is necessarily included in the same buffer as the payload. In order to do this a new structure is used: io_uring_recvmsg_out. This specifies the length written of the name, control and payload. As well as including the flags. The layout of the buffer is
where the lengths are those specified in the original msghdr used to issue the recvms= g. I suspect this API will be the most contentious part of this series and wou= ld appreciate any comments on it. For completeness I considered having the original struct msghdr as the head= er, but size wise it is much bigger (72 bytes including an iovec vs 16 bytes he= re). Testing also showed a 1% slowdown in terms of QPS. Using a mini network tester [1] shows 14% QPS improvment using this API, ho= wever this is likely to go down to ~8% with the latest allocation cache added by = Jens. [1]: https://github.com/DylanZA/netbench/tree/main Patches 1,2 change the copy_msghdr code to take a user_msghdr as input Patch 3 is the multishot feature v3: * apply formatting comments * refactor io_recvmsg_prep_multishot to reduce casts * move some overflow logic into recvmsg_prep as only need to call it once v2: * Rebase without netbuf recycling provided by io_uring * Fix payload field output with MSG_TRUNC set to match recvmsg(2) Dylan Yudaken (3): net: copy from user before calling __copy_msghdr net: copy from user before calling __get_compat_msghdr io_uring: support multishot in recvmsg include/linux/socket.h | 7 +- include/net/compat.h | 5 +- include/uapi/linux/io_uring.h | 7 ++ io_uring/net.c | 216 ++++++++++++++++++++++++++++------ io_uring/net.h | 6 + net/compat.c | 39 +++--- net/socket.c | 37 +++--- 7 files changed, 232 insertions(+), 85 deletions(-) base-commit: 20898aeac6b82d8eb6247754494584b2f6cafd53 --=20 2.30.2