public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH liburing] examples/io_uring-udp: Use a proper cast for `(struct sockaddr *)` argument
@ 2022-07-26 16:44 Ammar Faizi
  2022-07-26 16:47 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Ammar Faizi @ 2022-07-26 16:44 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Ammar Faizi, Fernanda Ma'rouf, Pavel Begunkov,
	io-uring Mailing List, GNU/Weeb Mailing List, Dylan Yudaken,
	Facebook Kernel Team

From: Ammar Faizi <[email protected]>

Sometimes the compiler accepts `(struct sockaddr_in *)` and
`(struct sockaddr_in6 *)` to be passed in to `(struct sockaddr *)`
without a cast. But not all compilers agree with that. Building with
clang 13.0.1 yields the following errors:

    io_uring-udp.c:134:18: error: incompatible pointer types passing \
    'struct sockaddr_in6 *' to parameter of type 'const struct sockaddr *' \
    [-Werror,-Wincompatible-pointer-types

    io_uring-udp.c:142:18: error: incompatible pointer types passing \
    'struct sockaddr_in *' to parameter of type 'const struct sockaddr *' \
    [-Werror,-Wincompatible-pointer-types]

Explicitly cast the pointer to (struct sockaddr *) to avoid this error.

Cc: Dylan Yudaken <[email protected]>
Cc: Facebook Kernel Team <[email protected]>
Fixes: 61d472b51e761e61cbf46caea40aaf40d8ed1484 ("add an example for a UDP server")
Signed-off-by: Ammar Faizi <[email protected]>
---
 examples/io_uring-udp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/examples/io_uring-udp.c b/examples/io_uring-udp.c
index 77472df..b4ef0a3 100644
--- a/examples/io_uring-udp.c
+++ b/examples/io_uring-udp.c
@@ -131,7 +131,7 @@ static int setup_sock(int af, int port)
 			.sin6_addr = IN6ADDR_ANY_INIT
 		};
 
-		ret = bind(fd, &addr6, sizeof(addr6));
+		ret = bind(fd, (struct sockaddr *) &addr6, sizeof(addr6));
 	} else {
 		struct sockaddr_in addr = {
 			.sin_family = af,
@@ -139,7 +139,7 @@ static int setup_sock(int af, int port)
 			.sin_addr = { INADDR_ANY }
 		};
 
-		ret = bind(fd, &addr, sizeof(addr));
+		ret = bind(fd, (struct sockaddr *) &addr, sizeof(addr));
 	}
 
 	if (ret) {

base-commit: 61d472b51e761e61cbf46caea40aaf40d8ed1484
-- 
Ammar Faizi


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH liburing] examples/io_uring-udp: Use a proper cast for `(struct sockaddr *)` argument
  2022-07-26 16:44 [PATCH liburing] examples/io_uring-udp: Use a proper cast for `(struct sockaddr *)` argument Ammar Faizi
@ 2022-07-26 16:47 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2022-07-26 16:47 UTC (permalink / raw)
  To: ammarfaizi2
  Cc: asml.silence, gwml, dylany, fernandafmr12, kernel-team, io-uring

On Tue, 26 Jul 2022 23:44:59 +0700, Ammar Faizi wrote:
> From: Ammar Faizi <[email protected]>
> 
> Sometimes the compiler accepts `(struct sockaddr_in *)` and
> `(struct sockaddr_in6 *)` to be passed in to `(struct sockaddr *)`
> without a cast. But not all compilers agree with that. Building with
> clang 13.0.1 yields the following errors:
> 
> [...]

Applied, thanks!

[1/1] examples/io_uring-udp: Use a proper cast for `(struct sockaddr *)` argument
      commit: 1842b2a74f4e914cb094019d0f339baeffa3023b

Best regards,
-- 
Jens Axboe



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-07-26 16:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-26 16:44 [PATCH liburing] examples/io_uring-udp: Use a proper cast for `(struct sockaddr *)` argument Ammar Faizi
2022-07-26 16:47 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox