public inbox for [email protected]
 help / color / mirror / Atom feed
From: Florian Fischer <[email protected]>
To: Bart Van Assche <[email protected]>
Cc: [email protected], Florian Schmaus <[email protected]>
Subject: Re: [PATCH liburing] add additional meson build system support
Date: Wed, 27 Jul 2022 22:53:29 +0200	[thread overview]
Message-ID: <20220727205329.jgr5i5ou4oxc2ttc@pasture> (raw)
In-Reply-To: <[email protected]>

On 27.07.2022 12:21, Bart Van Assche wrote:
> On 7/27/22 08:27, Florian Fischer wrote:
> >   11 files changed, 619 insertions(+), 4 deletions(-)
> 
> To me this diffstat tells me that this patch series adds a lot of complexity
> instead of removing complexity.

That's because Jens wants to keep both build systems in the repository.

 .github/workflows/build.yml      |  44 +++++--
 .gitignore                       |   2 +
 Makefile                         |  84 ------------
 Makefile.common                  |   6 -
 Makefile.quiet                   |  11 --
 configure                        | 467 -----------------------------------------------------------------
 examples/Makefile                |  41 ------
 examples/meson.build             |  19 +++
 man/meson.build                  | 116 ++++++++++++++++
 meson.build                      | 119 +++++++++++++++++
 meson_options.txt                |  14 ++
 src/Makefile                     |  87 ------------
 src/include/liburing/compat.h.in |   7 +
 src/include/liburing/meson.build |  51 +++++++
 src/include/meson.build          |   3 +
 src/meson.build                  |  28 ++++
 test/Makefile                    | 238 ---------------------------------
 test/meson.build                 | 219 +++++++++++++++++++++++++++++++
 18 files changed, 609 insertions(+), 947 deletions(-)

This is what the diffstat could look like if we would remove the old build system.


> That leaves me wondering what the advantages of this patch series are?

The most notable advantages of having a meson-based build system are highlighted
in the cover mail.

For me the by far most important feature and why I maintained the initial meson
code from 2021 is the interoperability with other meson-based projects.

Everything needed to consume liburing is to have a wrap file for liburing in your
subprojects directory and use it in your meson build logic.

subprojects/liburing.wrap:

  [wrap-git]
  url = https://git.kernel.dk/liburing
  revision = master

And use the following lines in your meson code:

  liburing_proj = subproject('emper')
  liburing_dep = liburing_proj/get_variable('uring')
  # somehow use the dependency object

---
Florian Fischer

  reply	other threads:[~2022-07-27 20:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-27 15:27 [PATCH liburing] add additional meson build system support Florian Fischer
2022-07-27 15:27 ` [PATCH liburing 1/9] add Meson build system Florian Fischer
2022-07-27 15:27 ` [PATCH liburing 2/9] meson: update meson build files for liburing 2.3 Florian Fischer
2022-07-27 15:27 ` [PATCH liburing 3/9] meson: update available tests to " Florian Fischer
2022-07-27 15:27 ` [PATCH liburing 4/9] meson: update installed manpages " Florian Fischer
2022-07-27 15:27 ` [PATCH liburing 5/9] meson: add default test setup running each test once Florian Fischer
2022-07-27 15:27 ` [PATCH liburing 6/9] meson: support building without libc Florian Fischer
2022-07-27 15:27 ` [PATCH liburing 7/9] meson: add 'raw' test suite Florian Fischer
2022-07-27 15:27 ` [PATCH liburing 8/9] github bot: add jobs for meson Florian Fischer
2022-07-27 15:27 ` [PATCH liburing 9/9] meson: update available examples to liburing 2.3 Florian Fischer
2022-07-27 19:21 ` [PATCH liburing] add additional meson build system support Bart Van Assche
2022-07-27 20:53   ` Florian Fischer [this message]
2022-07-29  7:47     ` Florian Schmaus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220727205329.jgr5i5ou4oxc2ttc@pasture \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox