public inbox for [email protected]
 help / color / mirror / Atom feed
From: Ammar Faizi <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Ammar Faizi <[email protected]>,
	Vitaly Chikunov <[email protected]>,
	Fernanda Ma'rouf <[email protected]>,
	Kanna Scarlet <[email protected]>,
	io-uring Mailing List <[email protected]>,
	GNU/Weeb Mailing List <[email protected]>
Subject: [PATCH liburing v1 03/10] test/file-verify: Fix reading from uninitialized buffer
Date: Wed, 10 Aug 2022 07:31:52 +0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

From: Ammar Faizi <[email protected]>

Fix this:

  ==3054556== Conditional jump or move depends on uninitialised value(s)
  ==3054556==    at 0x1099DB: verify_buf (file-verify.c:48)
  ==3054556==    by 0x10A506: test (file-verify.c:449)
  ==3054556==    by 0x109353: main (file-verify.c:538)

Link: https://github.com/axboe/liburing/issues/640
Reported-by: Vitaly Chikunov <[email protected]>
Signed-off-by: Ammar Faizi <[email protected]>
---
 test/file-verify.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/test/file-verify.c b/test/file-verify.c
index 595dafd..b1a8fd4 100644
--- a/test/file-verify.c
+++ b/test/file-verify.c
@@ -347,13 +347,16 @@ static int test(struct io_uring *ring, const char *fname, int buffered,
 				void *ptr;
 
 				t_posix_memalign(&ptr, 4096, CHUNK_SIZE / nr_vecs);
+				memset(ptr, 0, CHUNK_SIZE / nr_vecs);
 				vecs[j][i].iov_base = ptr;
 				vecs[j][i].iov_len = CHUNK_SIZE / nr_vecs;
 			}
 		}
 	} else {
-		for (j = 0; j < READ_BATCH; j++)
+		for (j = 0; j < READ_BATCH; j++) {
 			t_posix_memalign(&buf[j], 4096, CHUNK_SIZE);
+			memset(buf[j], 0, CHUNK_SIZE);
+		}
 		nr_vecs = 0;
 	}
 
-- 
Ammar Faizi


  parent reply	other threads:[~2022-08-10  0:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-10  0:31 [PATCH liburing v1 00/10] liburing test fixes Ammar Faizi
2022-08-10  0:31 ` [PATCH liburing v1 01/10] test/cq-overflow: Don't call `io_uring_queue_exit()` if the ring is not initialized Ammar Faizi
2022-08-10  0:31 ` [PATCH liburing v1 02/10] test/eeed8b54e0df: Initialize the `malloc()`ed buffer before `write()` Ammar Faizi
2022-08-10  0:31 ` Ammar Faizi [this message]
2022-08-10  0:31 ` [PATCH liburing v1 04/10] test/fixed-reuse: Fix reading from uninitialized array Ammar Faizi
2022-08-10  0:31 ` [PATCH liburing v1 05/10] test/fpos: Fix reading from uninitialized buffer Ammar Faizi
2022-08-10  0:31 ` [PATCH liburing v1 06/10] test/statx: " Ammar Faizi
2022-08-10  0:31 ` [PATCH liburing v1 07/10] test/submit-link-fail: Initialize the buffer before `write()` Ammar Faizi
2022-08-10  0:31 ` [PATCH liburing v1 08/10] test/232c93d07b74: Fix reading from uninitialized buffer Ammar Faizi
2022-08-10  0:31 ` [PATCH liburing v1 09/10] test/eventfd-disable: Fix reading uninitialized variable Ammar Faizi
2022-08-10  0:31 ` [PATCH liburing v1 10/10] test/file-register: Fix reading from uninitialized buffer Ammar Faizi
2022-08-10 13:03 ` [PATCH liburing v1 00/10] liburing test fixes Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox