From: Dylan Yudaken <[email protected]>
To: <[email protected]>, <[email protected]>
Cc: <[email protected]>, <[email protected]>,
Dylan Yudaken <[email protected]>
Subject: [PATCH liburing] handle buffered writes in read-write test
Date: Mon, 15 Aug 2022 10:09:14 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
When buffered writes are used then two things change:
1 - signals will propogate to the submit() call (as they would be
effectively ignored when going async)
2 - CQE ordering will change
Fix the read-write for both of these cases by ignoring the signal and
handling CQE ordering.
Signed-off-by: Dylan Yudaken <[email protected]>
---
test/read-write.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/test/read-write.c b/test/read-write.c
index c5cc469f258d..f50e8242afa4 100644
--- a/test/read-write.c
+++ b/test/read-write.c
@@ -759,6 +759,7 @@ static int test_write_efbig(void)
goto err;
}
io_uring_prep_writev(sqe, fd, &vecs[i], 1, off);
+ io_uring_sqe_set_data64(sqe, i);
off += BS;
}
@@ -774,7 +775,7 @@ static int test_write_efbig(void)
fprintf(stderr, "wait_cqe=%d\n", ret);
goto err;
}
- if (i < 16) {
+ if (cqe->user_data < 16) {
if (cqe->res != BS) {
fprintf(stderr, "bad write: %d\n", cqe->res);
goto err;
@@ -819,6 +820,8 @@ int main(int argc, char *argv[])
t_create_file(fname, FILE_SIZE);
}
+ signal(SIGXFSZ, SIG_IGN);
+
vecs = t_create_buffers(BUFFERS, BS);
/* if we don't have nonvec read, skip testing that */
base-commit: 15cc446cb8b0caa5c939423d31182eba66141539
--
2.30.2
next reply other threads:[~2022-08-15 17:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 17:09 Dylan Yudaken [this message]
2022-08-15 17:12 ` [PATCH liburing] handle buffered writes in read-write test Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox