From: Dylan Yudaken <[email protected]>
To: Jens Axboe <[email protected]>,
Pavel Begunkov <[email protected]>,
<[email protected]>
Cc: <[email protected]>, Dylan Yudaken <[email protected]>
Subject: [PATCH for-next v4 7/7] io_uring: trace local task work run
Date: Tue, 30 Aug 2022 05:50:13 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
Add tracing for io_run_local_task_work
Signed-off-by: Dylan Yudaken <[email protected]>
---
include/trace/events/io_uring.h | 29 +++++++++++++++++++++++++++++
io_uring/io_uring.c | 3 +++
2 files changed, 32 insertions(+)
diff --git a/include/trace/events/io_uring.h b/include/trace/events/io_uring.h
index c5b21ff0ac85..936fd41bf147 100644
--- a/include/trace/events/io_uring.h
+++ b/include/trace/events/io_uring.h
@@ -655,6 +655,35 @@ TRACE_EVENT(io_uring_short_write,
__entry->wanted, __entry->got)
);
+/*
+ * io_uring_local_work_run - ran ring local task work
+ *
+ * @tctx: pointer to a io_uring_ctx
+ * @count: how many functions it ran
+ * @loops: how many loops it ran
+ *
+ */
+TRACE_EVENT(io_uring_local_work_run,
+
+ TP_PROTO(void *ctx, int count, unsigned int loops),
+
+ TP_ARGS(ctx, count, loops),
+
+ TP_STRUCT__entry (
+ __field(void *, ctx )
+ __field(int, count )
+ __field(unsigned int, loops )
+ ),
+
+ TP_fast_assign(
+ __entry->ctx = ctx;
+ __entry->count = count;
+ __entry->loops = loops;
+ ),
+
+ TP_printk("ring %p, count %d, loops %u", __entry->ctx, __entry->count, __entry->loops)
+);
+
#endif /* _TRACE_IO_URING_H */
/* This part must be outside protection */
diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index fffa81e498a4..cdd8d10e9638 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -1165,6 +1165,7 @@ int io_run_local_work(struct io_ring_ctx *ctx)
struct llist_node fake;
struct llist_node *current_final = NULL;
int ret;
+ unsigned int loops = 1;
if (unlikely(ctx->submitter_task != current)) {
/* maybe this is before any submissions */
@@ -1194,6 +1195,7 @@ int io_run_local_work(struct io_ring_ctx *ctx)
node = io_llist_cmpxchg(&ctx->work_llist, &fake, NULL);
if (node != &fake) {
+ loops++;
current_final = &fake;
node = io_llist_xchg(&ctx->work_llist, &fake);
goto again;
@@ -1203,6 +1205,7 @@ int io_run_local_work(struct io_ring_ctx *ctx)
io_submit_flush_completions(ctx);
mutex_unlock(&ctx->uring_lock);
}
+ trace_io_uring_local_work_run(ctx, ret, loops);
return ret;
}
--
2.30.2
next prev parent reply other threads:[~2022-08-30 12:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 12:50 [PATCH for-next v4 0/7] io_uring: defer task work to when it is needed Dylan Yudaken
2022-08-30 12:50 ` [PATCH for-next v4 1/7] io_uring: remove unnecessary variable Dylan Yudaken
2022-08-30 12:50 ` [PATCH for-next v4 2/7] io_uring: introduce io_has_work Dylan Yudaken
2022-08-30 12:50 ` [PATCH for-next v4 3/7] io_uring: do not run task work at the start of io_uring_enter Dylan Yudaken
2022-08-30 12:50 ` [PATCH for-next v4 4/7] io_uring: add IORING_SETUP_DEFER_TASKRUN Dylan Yudaken
2022-08-30 12:50 ` [PATCH for-next v4 5/7] io_uring: move io_eventfd_put Dylan Yudaken
2022-08-30 12:50 ` [PATCH for-next v4 6/7] io_uring: signal registered eventfd to process deferred task work Dylan Yudaken
2022-08-30 12:50 ` Dylan Yudaken [this message]
2022-08-30 14:30 ` [PATCH for-next v4 0/7] io_uring: defer task work to when it is needed Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox