public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH] io_uring/notif: Remove the unused function io_notif_complete()
@ 2022-09-05  2:04 Jiapeng Chong
  2022-09-05 11:41 ` Pavel Begunkov
  2022-09-05 17:42 ` Jens Axboe
  0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2022-09-05  2:04 UTC (permalink / raw)
  To: axboe; +Cc: asml.silence, io-uring, linux-kernel, Jiapeng Chong, Abaci Robot

The function io_notif_complete() is defined in the notif.c file, but not
called elsewhere, so delete this unused function.

io_uring/notif.c:24:20: warning: unused function 'io_notif_complete' [-Wunused-function].

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2047
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
 io_uring/notif.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/io_uring/notif.c b/io_uring/notif.c
index 96f076b175e0..1a7abd7e5ca5 100644
--- a/io_uring/notif.c
+++ b/io_uring/notif.c
@@ -21,14 +21,6 @@ static void __io_notif_complete_tw(struct io_kiocb *notif, bool *locked)
 	io_req_task_complete(notif, locked);
 }
 
-static inline void io_notif_complete(struct io_kiocb *notif)
-	__must_hold(&notif->ctx->uring_lock)
-{
-	bool locked = true;
-
-	__io_notif_complete_tw(notif, &locked);
-}
-
 static void io_uring_tx_zerocopy_callback(struct sk_buff *skb,
 					  struct ubuf_info *uarg,
 					  bool success)
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] io_uring/notif: Remove the unused function io_notif_complete()
  2022-09-05  2:04 [PATCH] io_uring/notif: Remove the unused function io_notif_complete() Jiapeng Chong
@ 2022-09-05 11:41 ` Pavel Begunkov
  2022-09-05 17:42 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Pavel Begunkov @ 2022-09-05 11:41 UTC (permalink / raw)
  To: Jiapeng Chong, axboe; +Cc: io-uring, linux-kernel, Abaci Robot

On 9/5/22 03:04, Jiapeng Chong wrote:
> The function io_notif_complete() is defined in the notif.c file, but not
> called elsewhere, so delete this unused function.

Yep, forgot to kill it, LGTM

Reviewed-by: Pavel Begunkov <[email protected]>


> io_uring/notif.c:24:20: warning: unused function 'io_notif_complete' [-Wunused-function].
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2047
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
>   io_uring/notif.c | 8 --------
>   1 file changed, 8 deletions(-)
> 
> diff --git a/io_uring/notif.c b/io_uring/notif.c
> index 96f076b175e0..1a7abd7e5ca5 100644
> --- a/io_uring/notif.c
> +++ b/io_uring/notif.c
> @@ -21,14 +21,6 @@ static void __io_notif_complete_tw(struct io_kiocb *notif, bool *locked)
>   	io_req_task_complete(notif, locked);
>   }
>   
> -static inline void io_notif_complete(struct io_kiocb *notif)
> -	__must_hold(&notif->ctx->uring_lock)
> -{
> -	bool locked = true;
> -
> -	__io_notif_complete_tw(notif, &locked);
> -}
> -
>   static void io_uring_tx_zerocopy_callback(struct sk_buff *skb,
>   					  struct ubuf_info *uarg,
>   					  bool success)

-- 
Pavel Begunkov

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] io_uring/notif: Remove the unused function io_notif_complete()
  2022-09-05  2:04 [PATCH] io_uring/notif: Remove the unused function io_notif_complete() Jiapeng Chong
  2022-09-05 11:41 ` Pavel Begunkov
@ 2022-09-05 17:42 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2022-09-05 17:42 UTC (permalink / raw)
  To: Jiapeng Chong; +Cc: linux-kernel, asml.silence, Abaci Robot, io-uring

On Mon, 5 Sep 2022 10:04:36 +0800, Jiapeng Chong wrote:
> The function io_notif_complete() is defined in the notif.c file, but not
> called elsewhere, so delete this unused function.
> 
> io_uring/notif.c:24:20: warning: unused function 'io_notif_complete' [-Wunused-function].
> 
> 

Applied, thanks!

[1/1] io_uring/notif: Remove the unused function io_notif_complete()
      commit: 4fa07edbb7eacfb56b3aa64f590e9f38e7f1042c

Best regards,
-- 
Jens Axboe



^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-05 17:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-05  2:04 [PATCH] io_uring/notif: Remove the unused function io_notif_complete() Jiapeng Chong
2022-09-05 11:41 ` Pavel Begunkov
2022-09-05 17:42 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox