From: "Alexander V. Buev" <[email protected]>
To: Keith Busch <[email protected]>
Cc: <[email protected]>, <[email protected]>,
Jens Axboe <[email protected]>, Christoph Hellwig <[email protected]>,
"Martin K . Petersen" <[email protected]>,
Pavel Begunkov <[email protected]>,
Chaitanya Kulkarni <[email protected]>,
Mikhail Malygin <[email protected]>, <[email protected]>
Subject: Re: [PATCH v5 0/3] implement direct IO with integrity
Date: Wed, 21 Sep 2022 12:26:09 +0300 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
> «Внимание! Данное письмо от внешнего адресата!»
>
> On Tue, Sep 20, 2022 at 05:46:15PM +0300, Alexander V. Buev wrote:
> > This series of patches makes possible to do direct block IO
> > with integrity payload using io uring kernel interface.
> > Userspace app can utilize new READV_PI/WRITEV_PI operation with a new
> > fields in sqe struct (pi_addr/pi_len) to provide iovec's with
> > integrity data.
>
> Is this really intended to be used exclusively for PI? Once you give use space
> access to extended metadata regions, they can use it for whatever the user
> wants, which may not be related to protection information formats. Perhaps a
> more generic suffix than "_PI" may be appropriate like _EXT or _META?
Currently we use this code for transfer block IO with meta information
from user space to special block device driver. This meta information includes PI and some other
information that helps driver to process IO with some optimization,
special option and etc. In the near feature we can extend this info die to increased
requirements for our product.
Also we can use this code for transfer IO with PI information from user space
to supported block devices such as nvme & scsi.
And you are right. Just for me "_meta" is more appropriate and abstract suffix for this,
but:
1. "PI" is shortly
2. "PI" and "integrity" is widely used in block layer code and I decided that
if it's called PI - everyone understands what exactly it is about.
3. User can read/write general info only in case of using special block layer driver.
Anyway I'm ready to rename this things.
May be it's enough to rename only userspace visible part?
(sqe struct members & op codes)
--
Alexander V. Buev
next prev parent reply other threads:[~2022-09-21 9:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 14:46 [PATCH v5 0/3] implement direct IO with integrity Alexander V. Buev
2022-09-20 14:46 ` [PATCH v5 1/3] block: bio-integrity: add PI iovec to bio Alexander V. Buev
2022-09-27 7:47 ` Christoph Hellwig
2022-09-20 14:46 ` [PATCH v5 2/3] block: io-uring: add READV_PI/WRITEV_PI operations Alexander V. Buev
2022-09-21 17:59 ` Jens Axboe
2022-09-22 12:48 ` Alexander V. Buev
2022-09-22 14:08 ` Jens Axboe
2022-09-20 14:46 ` [PATCH v5 3/3] block: fops: handle IOCB_USE_PI in direct IO Alexander V. Buev
2022-09-20 20:12 ` [PATCH v5 0/3] implement direct IO with integrity Keith Busch
2022-09-21 9:26 ` Alexander V. Buev [this message]
2022-09-22 14:09 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox