From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B93CDC32771 for ; Wed, 21 Sep 2022 10:25:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229918AbiIUKZj (ORCPT ); Wed, 21 Sep 2022 06:25:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229923AbiIUKZf (ORCPT ); Wed, 21 Sep 2022 06:25:35 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BC8146DB3; Wed, 21 Sep 2022 03:25:31 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 73B0D21B4F; Wed, 21 Sep 2022 10:25:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1663755930; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uc2QAr+yoTaVFOWMtK0aM/SSUiccdt8/MbfjLIOgBSQ=; b=WQJjMv8/qF7dT45kXeLCDrUn4shazFhYJLiSXmi6yiS6wblHHPjGBqn7kiIQOgZCfA/ctA r+pIm5puzySFcLpwm4+XlyG8HybqMr3mc6tMEIW8wqNWcQtTCOhPBRb9dROEt89BrJFBmy jb+7O80qzBFrtC/Ic8bf8LaqGtsvFfs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1663755930; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uc2QAr+yoTaVFOWMtK0aM/SSUiccdt8/MbfjLIOgBSQ=; b=boNoLZlcKN/A+Uq5tLqnWSfBaHfa3JgujhKso118IJiRtq69K3W6ShcV8jy7V7Mdi3/I4N Plg89NZne2h+NmDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2A7EC13A89; Wed, 21 Sep 2022 10:25:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id bjBgCZrmKmPYYgAAMHmgww (envelope-from ); Wed, 21 Sep 2022 10:25:30 +0000 Date: Wed, 21 Sep 2022 12:19:58 +0200 From: David Sterba To: David Sterba Cc: Stefan Roesch , kernel-team@fb.com, io-uring@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, axboe@kernel.dk, josef@toxicpanda.com, fdmanana@gmail.com Subject: Re: [PATCH v3 00/12] io-uring/btrfs: support async buffered writes Message-ID: <20220921101958.GE32411@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <20220912192752.3785061-1-shr@fb.com> <20220920122540.GY32411@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220920122540.GY32411@twin.jikos.cz> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Tue, Sep 20, 2022 at 02:25:40PM +0200, David Sterba wrote: > On Mon, Sep 12, 2022 at 12:27:40PM -0700, Stefan Roesch wrote: > > This patch series adds support for async buffered writes when using both > > btrfs and io-uring. Currently io-uring only supports buffered writes (for btrfs) > > in the slow path, by processing them in the io workers. With this patch series > > it is now possible to support buffered writes in the fast path. To be able to use > > the fast path, the required pages must be in the page cache, the required locks > > in btrfs can be granted immediately and no additional blocks need to be read > > form disk. > > > > This patch series makes use of the changes that have been introduced by a > > previous patch series: "io-uring/xfs: support async buffered writes" > > > > Performance results: > > > > The new patch improves throughput by over two times (compared to the exiting > > behavior, where buffered writes are processed by an io-worker process) and also > > the latency is considerably reduced. Detailled results are part of the changelog > > of the first commit. > > Thanks. It's late for including this patches to 6.1 queue but it's now > in for-next and will be added to misc-next after rc1, targeting merge to > 6.2. I did some minor fixups, so please don't resend full series unless > there's a significant change. Incremental changes are fine if needed. I'm revisiting the merge target, the potential risk seems to be low here, straightforward changes for a separate feature, so it's now in the 6.1 queue. We still don't have ack for the function export so that would be good to have.