On Wed, Sep 28, 2022 at 07:18:05PM +0200, Christoph Hellwig wrote: > On Tue, Sep 27, 2022 at 11:06:06PM +0530, Kanchan Joshi wrote: > > if (bdev && meta_buffer && meta_len) { > > - meta = nvme_add_user_metadata(bio, meta_buffer, meta_len, > > - meta_seed, write); > > + meta = nvme_add_user_metadata(req, meta_buffer, meta_len, > > Pleae avoid the overly long line here. > sure, will fold it in, in the next iteration > Otherwise looks good: > > Reviewed-by: Christoph Hellwig > -- Anuj Gupta