From: Jonathan Lemon <[email protected]>
To: <[email protected]>
Cc: <[email protected]>
Subject: [RFC PATCH v2 07/13] io_uring: Allocate the zctap buffers for the device
Date: Tue, 18 Oct 2022 12:15:56 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
The idea is to register a memory region with the device, and
later specify the desired packet buffer size. The code currently
assumes a page size.
Create the desired number of zctap buffers and DMA map them
to the target device, recording the dma address for later use.
Signed-off-by: Jonathan Lemon <[email protected]>
---
io_uring/zctap.c | 55 +++++++++++++++++++++++++++++++++++++++++-------
1 file changed, 47 insertions(+), 8 deletions(-)
diff --git a/io_uring/zctap.c b/io_uring/zctap.c
index 46ba0d011250..a924e59513a4 100644
--- a/io_uring/zctap.c
+++ b/io_uring/zctap.c
@@ -22,7 +22,9 @@ struct ifq_region {
int count;
int nr_pages;
u16 id;
- struct page *freelist[];
+
+ struct io_zctap_buf *buf;
+ struct io_zctap_buf *freelist[];
};
typedef int (*bpf_op_t)(struct net_device *dev, struct netdev_bpf *bpf);
@@ -62,35 +64,65 @@ static void io_remove_ifq_region(struct ifq_region *ifr)
set_page_private(page, 0);
}
+ kvfree(ifr->buf);
kvfree(ifr);
}
-static int io_zctap_map_region(struct ifq_region *ifr)
+static inline struct device *
+netdev2device(struct net_device *dev)
+{
+ return dev->dev.parent; /* from SET_NETDEV_DEV() */
+}
+
+static int io_zctap_map_region(struct ifq_region *ifr, struct device *device)
{
struct io_mapped_ubuf *imu;
+ struct io_zctap_buf *buf;
struct page *page;
+ dma_addr_t addr;
+ int i, err;
u64 info;
- int i;
imu = ifr->imu;
for (i = 0; i < ifr->nr_pages; i++) {
page = imu->bvec[i].bv_page;
- if (PagePrivate(page))
+
+ if (PagePrivate(page)) {
+ err = -EEXIST;
goto out;
+ }
+
SetPagePrivate(page);
info = zctap_mk_page_info(ifr->id, i);
zctap_set_page_info(page, info);
- ifr->freelist[i] = page;
+
+ buf = &ifr->buf[i];
+ addr = dma_map_page_attrs(device, page, 0, PAGE_SIZE,
+ DMA_BIDIRECTIONAL,
+ DMA_ATTR_SKIP_CPU_SYNC);
+ if (dma_mapping_error(device, addr)) {
+ err = -ENOMEM;
+ goto out;
+ }
+ buf->dma = addr;
+ buf->page = page;
+ atomic_set(&buf->refcount, 0);
+
+ ifr->freelist[i] = buf;
}
return 0;
out:
while (i--) {
page = imu->bvec[i].bv_page;
- ClearPagePrivate(page);
set_page_private(page, 0);
+ ClearPagePrivate(page);
+ buf = &ifr->buf[i];
+ dma_unmap_page_attrs(device, buf->dma, PAGE_SIZE,
+ DMA_BIDIRECTIONAL,
+ DMA_ATTR_SKIP_CPU_SYNC);
}
- return -EEXIST;
+ return err;
}
int io_provide_ifq_region(struct io_zctap_ifq *ifq, u16 id)
@@ -119,13 +151,20 @@ int io_provide_ifq_region(struct io_zctap_ifq *ifq, u16 id)
if (!ifr)
return -ENOMEM;
+ ifr->buf = kvmalloc_array(nr_pages, sizeof(*ifr->buf), GFP_KERNEL);
+ if (!ifr->buf) {
+ kvfree(ifr);
+ return -ENOMEM;
+ }
+
ifr->nr_pages = nr_pages;
ifr->imu = imu;
ifr->count = nr_pages;
ifr->id = id;
- err = io_zctap_map_region(ifr);
+ err = io_zctap_map_region(ifr, netdev2device(ifq->dev));
if (err) {
+ kvfree(ifr->buf);
kvfree(ifr);
return err;
}
--
2.30.2
next prev parent reply other threads:[~2022-10-18 19:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 19:15 [RFC PATCH v2 00/13] zero-copy RX for io_uring Jonathan Lemon
2022-10-18 19:15 ` [RFC PATCH v2 01/13] io_uring: add zctap ifq definition Jonathan Lemon
2022-10-18 19:15 ` [RFC PATCH v2 02/13] netdevice: add SETUP_ZCTAP to the netdev_bpf structure Jonathan Lemon
2022-10-18 19:15 ` [RFC PATCH v2 03/13] io_uring: add register ifq opcode Jonathan Lemon
2022-10-18 19:15 ` [RFC PATCH v2 04/13] io_uring: create a zctap region for a mapped buffer Jonathan Lemon
2022-10-18 19:15 ` [RFC PATCH v2 05/13] io_uring: create page freelist for the ifq region Jonathan Lemon
2022-10-18 19:15 ` [RFC PATCH v2 06/13] io_uring: Provide driver API for zctap packet buffers Jonathan Lemon
2022-10-18 19:15 ` Jonathan Lemon [this message]
2022-10-18 19:15 ` [RFC PATCH v2 08/13] io_uring: Add zctap buffer get/put functions and refcounting Jonathan Lemon
2022-10-18 19:15 ` [RFC PATCH v2 09/13] skbuff: Introduce SKBFL_FIXED_FRAG and skb_fixed() Jonathan Lemon
2022-10-18 19:15 ` [RFC PATCH v2 10/13] io_uring: Allocate a uarg for use by the ifq RX Jonathan Lemon
2022-10-18 19:16 ` [RFC PATCH v2 11/13] io_uring: Define the zctap iov[] returned to the user Jonathan Lemon
2022-10-18 19:16 ` [RFC PATCH v2 12/13] io_uring: add OP_RECV_ZC command Jonathan Lemon
2022-10-18 19:16 ` [RFC PATCH v2 13/13] io_uring: Make remove_ifq_region a delayed work call Jonathan Lemon
2022-10-20 3:35 ` [RFC PATCH v2 00/13] zero-copy RX for io_uring Ziyang Zhang
2022-11-02 23:33 ` Jonathan Lemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox