public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH liburing v1 0/3] Clean up clang `-Wshorten-64-to-32` warnings
@ 2022-10-20 11:52 Ammar Faizi
  2022-10-20 11:52 ` [PATCH liburing v1 1/3] liburing: Clean up `-Wshorten-64-to-32` warnings from clang Ammar Faizi
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Ammar Faizi @ 2022-10-20 11:52 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Dylan Yudaken, Ammar Faizi, Pavel Begunkov, GNU/Weeb Mailing List,
	io-uring Mailing List, Facebook Kernel Team

From: Ammar Faizi <[email protected]>

Hi Jens,

Please consider this small cleanup series before the release.

This series is a follow up of the clean up `-Wshorten-64-to-32`
warnings that I discussed with Dylan previously. It only addresses
the warnings in the src/ dir (main library). We ignore the tests
for now.

`-Wshorten-64-to-32` is a clang-specific flag, it currently doesn't
exist in GCC.

There are 3 patches in this series:

- Patch 1 is to clean up the warnings in the main library
  (this is based on a patch from Dylan).

  Taken from: https://github.com/DylanZA/liburing/commit/cdd6dfbb9019.patch

- Patch 2 is to introduce LIBURING_CFLAGS variable in the Makefile. We
  need this varaible to apply specific compiler flags to the main
  library only. Currently, this flag is only used by the GitHub bot.

- Patch 3 is to integrate `-Wshorten-64-to-32` flag to the GitHub bot.

Signed-off-by: Ammar Faizi <[email protected]>
---

Ammar Faizi (2):
  Makefile: Introduce `LIBURING_CFLAGS` variable
  github: Append `-Wshorten-64-to-32` flag for clang build

Dylan Yudaken (1):
  liburing: Clean up `-Wshorten-64-to-32` warnings from clang

 .github/workflows/build.yml |  4 ++++
 src/Makefile                |  5 ++++-
 src/arch/syscall-defs.h     |  4 ++--
 src/register.c              |  5 ++++-
 src/setup.c                 | 12 ++++++------
 src/syscall.h               |  4 ++--
 6 files changed, 22 insertions(+), 12 deletions(-)


base-commit: 2950c0c1b23ef6bc3cfa3646adbfeffc23fc59cf
-- 
Ammar Faizi


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-10-20 12:57 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-20 11:52 [PATCH liburing v1 0/3] Clean up clang `-Wshorten-64-to-32` warnings Ammar Faizi
2022-10-20 11:52 ` [PATCH liburing v1 1/3] liburing: Clean up `-Wshorten-64-to-32` warnings from clang Ammar Faizi
2022-10-20 12:12   ` Ammar Faizi
2022-10-20 12:52     ` Jens Axboe
2022-10-20 11:52 ` [PATCH liburing v1 2/3] Makefile: Introduce `LIBURING_CFLAGS` variable Ammar Faizi
2022-10-20 11:52 ` [PATCH liburing v1 3/3] github: Append `-Wshorten-64-to-32` flag for clang build Ammar Faizi
2022-10-20 12:53 ` [PATCH liburing v1 0/3] Clean up clang `-Wshorten-64-to-32` warnings Dylan Yudaken
2022-10-20 12:57   ` Ammar Faizi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox