public inbox for [email protected]
 help / color / mirror / Atom feed
From: Stefan Roesch <[email protected]>
To: [email protected]
Cc: [email protected], [email protected], [email protected],
	[email protected], [email protected],
	[email protected]
Subject: [RFC PATCH v4 3/3] io_uring: add api to set napi prefer busy poll
Date: Mon, 21 Nov 2022 09:29:53 -0800	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

This adds an api to register and unregister the napi prefer busy poll
setting from liburing. To be able to use this functionality, the
corresponding liburing patch is needed.

Signed-off-by: Stefan Roesch <[email protected]>
---
 include/uapi/linux/io_uring.h | 3 ++-
 io_uring/io_uring.c           | 5 ++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.h
index 1a713bbafaee..b74021454bf7 100644
--- a/include/uapi/linux/io_uring.h
+++ b/include/uapi/linux/io_uring.h
@@ -619,7 +619,8 @@ struct io_uring_buf_reg {
 /* argument for IORING_(UN)REGISTER_NAPI */
 struct io_uring_napi {
 	__u32	busy_poll_to;
-	__u32	pad;
+	__u8    prefer_busy_poll;
+	__u8	pad[3];
 	__u64	resv;
 };
 
diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index cf0e7cc8ad2e..dd903c71fa20 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -4127,6 +4127,7 @@ static int io_register_napi(struct io_ring_ctx *ctx, void __user *arg)
 #ifdef CONFIG_NET_RX_BUSY_POLL
 	const struct io_uring_napi curr = {
 		.busy_poll_to = ctx->napi_busy_poll_to,
+		.prefer_busy_poll = ctx->napi_prefer_busy_poll
 	};
 	struct io_uring_napi *napi;
 
@@ -4135,7 +4136,7 @@ static int io_register_napi(struct io_ring_ctx *ctx, void __user *arg)
 		return PTR_ERR(napi);
 
 	WRITE_ONCE(ctx->napi_busy_poll_to, napi->busy_poll_to);
-
+	WRITE_ONCE(ctx->napi_prefer_busy_poll, !!napi->prefer_busy_poll);
 	kfree(napi);
 
 	if (copy_to_user(arg, &curr, sizeof(curr)))
@@ -4152,12 +4153,14 @@ static int io_unregister_napi(struct io_ring_ctx *ctx, void __user *arg)
 #ifdef CONFIG_NET_RX_BUSY_POLL
 	const struct io_uring_napi curr = {
 		.busy_poll_to = ctx->napi_busy_poll_to,
+		.prefer_busy_poll = ctx->napi_prefer_busy_poll
 	};
 
 	if (copy_to_user(arg, &curr, sizeof(curr)))
 		return -EFAULT;
 
 	WRITE_ONCE(ctx->napi_busy_poll_to, 0);
+	WRITE_ONCE(ctx->napi_prefer_busy_poll, false);
 	return 0;
 #else
 	return -EINVAL;
-- 
2.30.2


      parent reply	other threads:[~2022-11-21 17:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21 17:29 [RFC PATCH v4 0/3] io_uring: add napi busy polling support Stefan Roesch
2022-11-21 17:29 ` [RFC PATCH v4 1/3] " Stefan Roesch
2022-11-21 17:29 ` [RFC PATCH v4 2/3] io_uring: add api to set / get napi configuration Stefan Roesch
2022-11-21 17:35   ` Jens Axboe
2022-11-21 18:55     ` Stefan Roesch
2022-11-21 17:37   ` Jens Axboe
2022-11-21 18:55     ` Stefan Roesch
2022-11-21 17:45   ` Ammar Faizi
2022-11-21 18:56     ` Stefan Roesch
2022-11-21 17:29 ` Stefan Roesch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox