public inbox for [email protected]
 help / color / mirror / Atom feed
From: Ammar Faizi <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Ammar Faizi <[email protected]>,
	Pavel Begunkov <[email protected]>,
	io-uring Mailing List <[email protected]>,
	GNU/Weeb Mailing List <[email protected]>,
	Gilang Fachrezy <[email protected]>,
	Muhammad Rizki <[email protected]>,
	Alviro Iskandar Setiawan <[email protected]>,
	VNLX Kernel Department <[email protected]>
Subject: [PATCH liburing v1 1/7] liburing.h: Export `__io_uring_flush_sq()` function
Date: Thu, 24 Nov 2022 15:00:56 +0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

From: Ammar Faizi <[email protected]>

clang says:

  queue.c:204:10: error: no previous prototype for function \
  '__io_uring_flush_sq' [-Werror,-Wmissing-prototypes] \
  unsigned __io_uring_flush_sq(struct io_uring *ring)
           ^
  queue.c:204:1: note: declare 'static' if the function is not intended \
  to be used outside of this translation unit \
  unsigned __io_uring_flush_sq(struct io_uring *ring)

This function is used by test/iopoll.c, therefore, it can't be static.
Export it.

Signed-off-by: Ammar Faizi <[email protected]>
---
 src/include/liburing.h | 1 +
 src/liburing.map       | 5 +++++
 2 files changed, 6 insertions(+)

diff --git a/src/include/liburing.h b/src/include/liburing.h
index 12a703f..c1d8edb 100644
--- a/src/include/liburing.h
+++ b/src/include/liburing.h
@@ -237,6 +237,7 @@ int io_uring_register_file_alloc_range(struct io_uring *ring,
 
 int io_uring_get_events(struct io_uring *ring);
 int io_uring_submit_and_get_events(struct io_uring *ring);
+unsigned __io_uring_flush_sq(struct io_uring *ring);
 
 /*
  * io_uring syscalls.
diff --git a/src/liburing.map b/src/liburing.map
index 06c64f8..6b2f4b2 100644
--- a/src/liburing.map
+++ b/src/liburing.map
@@ -67,3 +67,8 @@ LIBURING_2.3 {
 		io_uring_get_events;
 		io_uring_submit_and_get_events;
 } LIBURING_2.2;
+
+LIBURING_2.4 {
+	global:
+		__io_uring_flush_sq;
+} LIBURING_2.3;
-- 
Ammar Faizi


  reply	other threads:[~2022-11-24  8:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-24  8:00 [PATCH liburing v1 0/7] Ensure we mark internal functions and variables as static Ammar Faizi
2022-11-24  8:00 ` Ammar Faizi [this message]
2022-11-24 10:14   ` [PATCH liburing v1 1/7] liburing.h: Export `__io_uring_flush_sq()` function Dylan Yudaken
2022-11-24 11:47     ` Ammar Faizi
2022-11-24 13:27       ` Jens Axboe
2022-11-24  8:00 ` [PATCH liburing v1 2/7] test/io_uring_setup: Remove unused functions Ammar Faizi
2022-11-24  8:00 ` [PATCH liburing v1 3/7] ucontext-cp: Remove an unused function Ammar Faizi
2022-11-24  8:00 ` [PATCH liburing v1 4/7] tests: Mark internal functions as static Ammar Faizi
2022-11-24  8:01 ` [PATCH liburing v1 5/7] ucontext-cp: " Ammar Faizi
2022-11-24  8:01 ` [PATCH liburing v1 6/7] test/Makefile: Omit `-Wmissing-prototypes` from the C++ compiler flags Ammar Faizi
2022-11-24  8:01 ` [PATCH liburing v1 7/7] github: Add `-Wmissing-prototypes` for GitHub CI bot Ammar Faizi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox