From: Ammar Faizi <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Ammar Faizi <[email protected]>,
Pavel Begunkov <[email protected]>,
io-uring Mailing List <[email protected]>,
GNU/Weeb Mailing List <[email protected]>,
Gilang Fachrezy <[email protected]>,
Muhammad Rizki <[email protected]>,
Alviro Iskandar Setiawan <[email protected]>,
VNLX Kernel Department <[email protected]>
Subject: [PATCH liburing v1 3/7] ucontext-cp: Remove an unused function
Date: Thu, 24 Nov 2022 15:00:58 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
From: Ammar Faizi <[email protected]>
When marking all internal functions as static after an attempt to
integrate `-Wmissing-prototypes` flag. An unused function is found:
ucontext-cp.c:71:12: error: ‘await_poll’ defined but not used [-Werror=unused-function]
71 | static int await_poll(async_context *pctx, int fd, short poll_mask)
| ^~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:36: ucontext-cp] Error 1
Remove it.
Signed-off-by: Ammar Faizi <[email protected]>
---
examples/ucontext-cp.c | 19 ++-----------------
1 file changed, 2 insertions(+), 17 deletions(-)
diff --git a/examples/ucontext-cp.c b/examples/ucontext-cp.c
index 281013f..ed3b342 100644
--- a/examples/ucontext-cp.c
+++ b/examples/ucontext-cp.c
@@ -68,23 +68,8 @@ DEFINE_AWAIT_OP(readv)
DEFINE_AWAIT_OP(writev)
#undef DEFINE_AWAIT_OP
-int await_poll(async_context *pctx, int fd, short poll_mask) {
- struct io_uring_sqe *sqe = io_uring_get_sqe(pctx->ring);
- struct io_uring_cqe *cqe;
- if (!sqe)
- return -1;
-
- io_uring_prep_poll_add(sqe, fd, poll_mask);
- io_uring_sqe_set_data(sqe, pctx);
- swapcontext(&pctx->ctx_fnew, &pctx->ctx_main);
- io_uring_peek_cqe(pctx->ring, &cqe);
- assert(cqe);
- io_uring_cqe_seen(pctx->ring, cqe);
-
- return cqe->res;
-}
-
-int await_delay(async_context *pctx, time_t seconds) {
+int await_delay(async_context *pctx, time_t seconds)
+{
struct io_uring_sqe *sqe = io_uring_get_sqe(pctx->ring);
struct io_uring_cqe *cqe;
struct __kernel_timespec ts = {
--
Ammar Faizi
next prev parent reply other threads:[~2022-11-24 8:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 8:00 [PATCH liburing v1 0/7] Ensure we mark internal functions and variables as static Ammar Faizi
2022-11-24 8:00 ` [PATCH liburing v1 1/7] liburing.h: Export `__io_uring_flush_sq()` function Ammar Faizi
2022-11-24 10:14 ` Dylan Yudaken
2022-11-24 11:47 ` Ammar Faizi
2022-11-24 13:27 ` Jens Axboe
2022-11-24 8:00 ` [PATCH liburing v1 2/7] test/io_uring_setup: Remove unused functions Ammar Faizi
2022-11-24 8:00 ` Ammar Faizi [this message]
2022-11-24 8:00 ` [PATCH liburing v1 4/7] tests: Mark internal functions as static Ammar Faizi
2022-11-24 8:01 ` [PATCH liburing v1 5/7] ucontext-cp: " Ammar Faizi
2022-11-24 8:01 ` [PATCH liburing v1 6/7] test/Makefile: Omit `-Wmissing-prototypes` from the C++ compiler flags Ammar Faizi
2022-11-24 8:01 ` [PATCH liburing v1 7/7] github: Add `-Wmissing-prototypes` for GitHub CI bot Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox