From: Ammar Faizi <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Ammar Faizi <[email protected]>,
Dylan Yudaken <[email protected]>,
Pavel Begunkov <[email protected]>,
Gilang Fachrezy <[email protected]>,
Muhammad Rizki <[email protected]>,
Alviro Iskandar Setiawan <[email protected]>,
VNLX Kernel Department <[email protected]>,
io-uring Mailing List <[email protected]>,
GNU/Weeb Mailing List <[email protected]>
Subject: [PATCH liburing v2 0/8] Ensure we mark non-exported functions and variables as static
Date: Thu, 24 Nov 2022 23:28:53 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
From: Ammar Faizi <[email protected]>
Hi Jens,
This is a v2 revision.
This series is a -Wmissing-prototypes enforcement. -Wmissing-prototypes
is a clang C compiler flag that warns us if we have functions or
variables that are not used outisde the translation unit, but not marked
as static.
There are 8 patches in this series:
- Patch #1, is just a typo cleanup.
- Patch #2, core library change, mark __io_uring_flush_sq() as static.
- Patch #3 to patch #7 are the cleanup preparation for
-Wmissing-prototypes enforcement.
- Patch #8 is to enforce -Wmissing-prototypes on the GitHub CI robot.
This series has been build-tested each patch with the GitHub CI robot
and no breakage is found.
## Changelog
v2:
- Add a new patch #1, fix typo.
- Don't export __io_uring_flush_sq(). Instead, make a copy of this
function in test/helpers.c.
- Massage the commit message.
Signed-off-by: Ammar Faizi <[email protected]>
---
Ammar Faizi (8):
queue: Fix typo "entererd" -> "entered"
queue: Mark `__io_uring_flush_sq()` as static
test/io_uring_setup: Remove unused functions
ucontext-cp: Remove an unused function
tests: Mark non-exported functions as static
ucontext-cp: Mark a non-exported function as static
test/Makefile: Omit `-Wmissing-prototypes` from the C++ compiler flags
github: Add `-Wmissing-prototypes` for GitHub CI bot
.github/workflows/build.yml | 7 ++--
examples/ucontext-cp.c | 19 +--------
src/queue.c | 4 +-
test/Makefile | 11 ++++-
test/accept-link.c | 2 +-
test/accept-reuse.c | 9 ++--
test/ce593a6c480a.c | 4 +-
test/defer-taskrun.c | 2 +-
test/exit-no-cleanup.c | 2 +-
test/hardlink.c | 2 +-
test/helpers.c | 33 +++++++++++++++
test/helpers.h | 2 +
test/io_uring_passthrough.c | 2 -
test/io_uring_setup.c | 83 ++-----------------------------------
test/iopoll.c | 2 -
test/link_drain.c | 2 +-
test/multicqes_drain.c | 27 +++++++-----
test/nvme.h | 3 +-
test/poll-link.c | 2 +-
test/poll-mshot-overflow.c | 2 +-
test/read-before-exit.c | 2 +-
test/ring-leak2.c | 2 +-
test/sq-poll-kthread.c | 2 +-
test/sqpoll-cancel-hang.c | 2 +-
test/symlink.c | 3 +-
test/timeout-new.c | 12 ++++--
26 files changed, 101 insertions(+), 142 deletions(-)
base-commit: 636b6bdaa8d84f1b5318e27d1e4ffa86361ae66d
--
Ammar Faizi
WARNING: multiple messages have this Message-ID (diff)
From: Ammar Faizi <[email protected]>
To: Jens Axboe <[email protected]>
Cc: io-uring Mailing List <[email protected]>,
Ammar Faizi <[email protected]>,
Nicolai Stange <[email protected]>,
Yuriy Chernyshov <[email protected]>
Subject: [PATCH] test/sendmsg_fs_cve: Fix the wrong SPDX-License-Identifier
Date: Mon, 12 Dec 2022 19:48:57 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
Message-ID: <20221212124857.atCSNbq9bwMrO3RhTk2I4ld4PghCMDC2DjDRHJXfUvo@z> (raw)
From: Ammar Faizi <[email protected]>
This test program's license is GPL-2.0-or-later, but I put the wrong
SPDX-License-Identifier in commit:
d36db0b72b9 ("test: Add missing SPDX-License-Identifier")
Fix it.
Cc: Nicolai Stange <[email protected]>
Reported-by: Yuriy Chernyshov <[email protected]>
Fixes: https://github.com/axboe/liburing/issues/753
Fixes: d36db0b72b9399623dee12b61069845d8e1bfa05 ("test: Add missing SPDX-License-Identifier")
Signed-off-by: Ammar Faizi <[email protected]>
---
test/sendmsg_fs_cve.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/sendmsg_fs_cve.c b/test/sendmsg_fs_cve.c
index 2ce3114..9e444d7 100644
--- a/test/sendmsg_fs_cve.c
+++ b/test/sendmsg_fs_cve.c
@@ -1,11 +1,11 @@
-/* SPDX-License-Identifier: MIT */
+/* SPDX-License-Identifier: GPL-2.0-or-later */
/*
* repro-CVE-2020-29373 -- Reproducer for CVE-2020-29373.
*
* Copyright (c) 2021 SUSE
* Author: Nicolai Stange <[email protected]>
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
base-commit: 5f0cf68fc2cd28617a86976fc906447f737086d5
--
Ammar Faizi
next reply other threads:[~2022-11-24 16:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 16:28 Ammar Faizi [this message]
2022-11-24 16:28 ` [PATCH liburing v2 1/8] queue: Fix typo "entererd" -> "entered" Ammar Faizi
2022-11-24 16:28 ` [PATCH liburing v2 2/8] queue: Mark `__io_uring_flush_sq()` as static Ammar Faizi
2022-11-24 16:28 ` [PATCH liburing v2 3/8] test/io_uring_setup: Remove unused functions Ammar Faizi
2022-11-24 16:28 ` [PATCH liburing v2 4/8] ucontext-cp: Remove an unused function Ammar Faizi
2022-11-24 16:28 ` [PATCH liburing v2 5/8] tests: Mark non-exported functions as static Ammar Faizi
2022-11-24 16:28 ` [PATCH liburing v2 6/8] ucontext-cp: Mark a non-exported function " Ammar Faizi
2022-11-24 16:29 ` [PATCH liburing v2 7/8] test/Makefile: Omit `-Wmissing-prototypes` from the C++ compiler flags Ammar Faizi
2022-11-24 16:29 ` [PATCH liburing v2 8/8] github: Add `-Wmissing-prototypes` for GitHub CI bot Ammar Faizi
2022-11-28 14:15 ` [PATCH liburing v2 0/8] Ensure we mark non-exported functions and variables as static Jens Axboe
2022-12-12 12:48 ` [PATCH] test/sendmsg_fs_cve: Fix the wrong SPDX-License-Identifier Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox