From: Kees Cook <[email protected]>
To: Greg KH <[email protected]>
Cc: Jens Axboe <[email protected]>,
Pavel Begunkov <[email protected]>,
"Gustavo A. R. Silva" <[email protected]>,
[email protected], [email protected],
Dylan Yudaken <[email protected]>,
[email protected], [email protected]
Subject: Re: [PATCH] io_uring: Replace 0-length array with flexible array
Date: Thu, 5 Jan 2023 12:01:22 -0800 [thread overview]
Message-ID: <202301051159.9CBE8DE09@keescook> (raw)
In-Reply-To: <[email protected]>
[resend -- I failed to CC the thread]
On Thu, Jan 05, 2023 at 08:38:01PM +0100, Greg KH wrote:
> On Thu, Jan 05, 2023 at 10:04:19AM -0800, Kees Cook wrote:
> > On Thu, Jan 05, 2023 at 08:39:48AM +0100, Greg KH wrote:
> > > On Wed, Jan 04, 2023 at 07:37:48PM -0800, Kees Cook wrote:
> > > > Zero-length arrays are deprecated[1]. Replace struct io_uring_buf_ring's
> > > > "bufs" with a flexible array member. (How is the size of this array
> > > > verified?) Detected with GCC 13, using -fstrict-flex-arrays=3:
> > > >
> > > > In function 'io_ring_buffer_select',
> > > > inlined from 'io_buffer_select' at io_uring/kbuf.c:183:10:
> > > > io_uring/kbuf.c:141:23: warning: array subscript 255 is outside the bounds of an interior zero-length array 'struct io_uring_buf[0]' [-Wzero-length-bounds]
> > > > 141 | buf = &br->bufs[head];
> > > > | ^~~~~~~~~~~~~~~
> > > > In file included from include/linux/io_uring.h:7,
> > > > from io_uring/kbuf.c:10:
> > > > include/uapi/linux/io_uring.h: In function 'io_buffer_select':
> > > > include/uapi/linux/io_uring.h:628:41: note: while referencing 'bufs'
> > > > 628 | struct io_uring_buf bufs[0];
> > > > | ^~~~
> > > >
> > > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays
> > > >
> > > > Fixes: c7fb19428d67 ("io_uring: add support for ring mapped supplied buffers")
> > > > Cc: Jens Axboe <[email protected]>
> > > > Cc: Pavel Begunkov <[email protected]>
> > > > Cc: "Gustavo A. R. Silva" <[email protected]>
> > > > Cc: [email protected]
> > >
> > > Build problem aside, why is this a stable kernel issue?
> >
> > My thinking was that since this is technically a UAPI change, it'd be
> > best to get it changed as widely as possible.
>
> You can't break the uapi, so it should be the same with or without your
> change right?
>
> confused,
Correct -- but we've had a hard time finding breakages (with extremely
weird stuff like non-C .h file scrapers) due to the lag between making
UAPI changes like this.
Anyway, I can drop the CC stable if it's more sensible.
--
Kees Cook
prev parent reply other threads:[~2023-01-05 20:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 3:37 [PATCH] io_uring: Replace 0-length array with flexible array Kees Cook
2023-01-05 4:33 ` Kees Cook
2023-01-05 5:58 ` kernel test robot
2023-01-05 7:39 ` Greg KH
2023-01-05 18:04 ` Kees Cook
2023-01-05 19:38 ` Greg KH
2023-01-05 20:01 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202301051159.9CBE8DE09@keescook \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox