From: Gabriel Krisman Bertazi <[email protected]>
To: [email protected]
Cc: [email protected], Gabriel Krisman Bertazi <[email protected]>
Subject: [PATCH 0/2] io-wq: cleanup io_wq and io_wqe
Date: Tue, 21 Mar 2023 22:16:26 -0300 [thread overview]
Message-ID: <[email protected]> (raw)
Hi Jens,
This tides up the io-wq internal interface by dropping the io_wqe/io_wq
separation, which no longer makes sense since commit
0654b05e7e65 ("io_uring: One wqe per wq"). We currently have a single
io_wqe instance per io_wq, which is embedded in the structure. This
patchset merges the two, dropping bit of code to go from one to the
other in the io-wq implementation.
I don't expect it to have any positive impact on performance, of course,
since hopefully the compiler optimizes it, but still, it is nice clean
up. To be sure, I measured with some mmtests microbenchmarks and I haven't
seen differences with or without the patchset.
Patch 2 is slightly big to review but the use of wq and wqe is
intrinsically connected; it was a bit hard to break it in more pieces.
Tested by running liburing's testsuite and mmtests performance
microbenchmarks (which uses fio).
Based on your for-next branch.
Thanks,
Gabriel Krisman Bertazi (2):
io-wq: Move wq accounting to io_wq
io-wq: Drop struct io_wqe
io_uring/io-wq.c | 408 ++++++++++++++++++++++-------------------------
1 file changed, 189 insertions(+), 219 deletions(-)
--
2.35.3
next reply other threads:[~2023-03-22 1:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 1:16 Gabriel Krisman Bertazi [this message]
2023-03-22 1:16 ` [PATCH 1/2] io-wq: Move wq accounting to io_wq Gabriel Krisman Bertazi
2023-03-22 1:16 ` [PATCH 2/2] io-wq: Drop struct io_wqe Gabriel Krisman Bertazi
2023-03-23 19:19 ` [PATCH 0/2] io-wq: cleanup io_wq and io_wqe Jens Axboe
2023-03-23 19:31 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox