From: Ming Lei <[email protected]>
To: Jens Axboe <[email protected]>,
[email protected], [email protected]
Cc: [email protected],
Miklos Szeredi <[email protected]>,
ZiyangZhang <[email protected]>,
Xiaoguang Wang <[email protected]>,
Bernd Schubert <[email protected]>,
Pavel Begunkov <[email protected]>,
Stefan Hajnoczi <[email protected]>,
Ming Lei <[email protected]>
Subject: [PATCH V4 05/17] io_uring: support OP_SEND_ZC/OP_RECV for fused slave request
Date: Fri, 24 Mar 2023 21:57:56 +0800 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
Start to allow fused slave request to support OP_SEND_ZC/OP_RECV, and
the buffer can be retrieved from master request.
Once the slave request is completed, the master buffer will be returned
back.
Signed-off-by: Ming Lei <[email protected]>
---
io_uring/net.c | 30 ++++++++++++++++++++++++++++--
io_uring/opdef.c | 6 ++++++
2 files changed, 34 insertions(+), 2 deletions(-)
diff --git a/io_uring/net.c b/io_uring/net.c
index b7f190ca528e..bc33f89f61b3 100644
--- a/io_uring/net.c
+++ b/io_uring/net.c
@@ -16,6 +16,7 @@
#include "net.h"
#include "notif.h"
#include "rsrc.h"
+#include "fused_cmd.h"
#if defined(CONFIG_NET)
struct io_shutdown {
@@ -68,6 +69,13 @@ struct io_sr_msg {
struct io_kiocb *notif;
};
+#define user_ptr_to_u64(x) ( \
+{ \
+ typecheck(void __user *, (x)); \
+ (u64)(unsigned long)(x); \
+} \
+)
+
static inline bool io_check_multishot(struct io_kiocb *req,
unsigned int issue_flags)
{
@@ -378,7 +386,11 @@ int io_send(struct io_kiocb *req, unsigned int issue_flags)
if (unlikely(!sock))
return -ENOTSOCK;
- ret = import_ubuf(ITER_SOURCE, sr->buf, sr->len, &msg.msg_iter);
+ if (!(req->flags & REQ_F_FUSED_SLAVE))
+ ret = import_ubuf(ITER_SOURCE, sr->buf, sr->len, &msg.msg_iter);
+ else
+ ret = io_import_buf_for_slave(user_ptr_to_u64(sr->buf),
+ sr->len, ITER_SOURCE, &msg.msg_iter, req);
if (unlikely(ret))
return ret;
@@ -869,7 +881,11 @@ int io_recv(struct io_kiocb *req, unsigned int issue_flags)
sr->buf = buf;
}
- ret = import_ubuf(ITER_DEST, sr->buf, len, &msg.msg_iter);
+ if (!(req->flags & REQ_F_FUSED_SLAVE))
+ ret = import_ubuf(ITER_DEST, sr->buf, len, &msg.msg_iter);
+ else
+ ret = io_import_buf_for_slave(user_ptr_to_u64(sr->buf),
+ sr->len, ITER_DEST, &msg.msg_iter, req);
if (unlikely(ret))
goto out_free;
@@ -983,6 +999,9 @@ int io_send_zc_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
if (zc->flags & IORING_RECVSEND_FIXED_BUF) {
unsigned idx = READ_ONCE(sqe->buf_index);
+ if (req->flags & REQ_F_FUSED_SLAVE)
+ return -EINVAL;
+
if (unlikely(idx >= ctx->nr_user_bufs))
return -EFAULT;
idx = array_index_nospec(idx, ctx->nr_user_bufs);
@@ -1119,8 +1138,15 @@ int io_send_zc(struct io_kiocb *req, unsigned int issue_flags)
if (unlikely(ret))
return ret;
msg.sg_from_iter = io_sg_from_iter;
+ } else if (req->flags & REQ_F_FUSED_SLAVE) {
+ ret = io_import_buf_for_slave(user_ptr_to_u64(zc->buf),
+ zc->len, ITER_SOURCE, &msg.msg_iter, req);
+ if (unlikely(ret))
+ return ret;
+ msg.sg_from_iter = io_sg_from_iter;
} else {
io_notif_set_extended(zc->notif);
+
ret = import_ubuf(ITER_SOURCE, zc->buf, zc->len, &msg.msg_iter);
if (unlikely(ret))
return ret;
diff --git a/io_uring/opdef.c b/io_uring/opdef.c
index 9b376df91abd..e7d75bf69c0f 100644
--- a/io_uring/opdef.c
+++ b/io_uring/opdef.c
@@ -273,6 +273,8 @@ const struct io_issue_def io_issue_defs[] = {
.audit_skip = 1,
.ioprio = 1,
.manual_alloc = 1,
+ .fused_slave = 1,
+ .buf_dir = READ,
#if defined(CONFIG_NET)
.prep = io_sendmsg_prep,
.issue = io_send,
@@ -287,6 +289,8 @@ const struct io_issue_def io_issue_defs[] = {
.buffer_select = 1,
.audit_skip = 1,
.ioprio = 1,
+ .fused_slave = 1,
+ .buf_dir = WRITE,
#if defined(CONFIG_NET)
.prep = io_recvmsg_prep,
.issue = io_recv,
@@ -413,6 +417,8 @@ const struct io_issue_def io_issue_defs[] = {
.audit_skip = 1,
.ioprio = 1,
.manual_alloc = 1,
+ .fused_slave = 1,
+ .buf_dir = READ,
#if defined(CONFIG_NET)
.prep = io_send_zc_prep,
.issue = io_send_zc,
--
2.39.2
next prev parent reply other threads:[~2023-03-24 14:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230324135916epcas5p37aad4c49c76c05567a484377d8909092@epcas5p3.samsung.com>
2023-03-24 13:57 ` [PATCH V4 00/17] io_uring/ublk: add IORING_OP_FUSED_CMD Ming Lei
2023-03-24 13:57 ` [PATCH V4 01/17] io_uring: increase io_kiocb->flags into 64bit Ming Lei
2023-03-24 13:57 ` [PATCH V4 02/17] io_uring: add IORING_OP_FUSED_CMD Ming Lei
2023-03-24 13:57 ` [PATCH V4 03/17] io_uring: support normal SQE for fused command Ming Lei
2023-03-24 13:57 ` [PATCH V4 04/17] io_uring: support OP_READ/OP_WRITE for fused slave request Ming Lei
2023-03-24 13:57 ` Ming Lei [this message]
2023-03-24 13:57 ` [PATCH V4 06/17] block: ublk_drv: mark device as LIVE before adding disk Ming Lei
2023-03-24 13:57 ` [PATCH V4 07/17] block: ublk_drv: add common exit handling Ming Lei
2023-03-24 13:57 ` [PATCH V4 08/17] block: ublk_drv: don't consider flush request in map/unmap io Ming Lei
2023-03-24 13:58 ` [PATCH V4 09/17] block: ublk_drv: add two helpers to clean up map/unmap request Ming Lei
2023-03-24 13:58 ` [PATCH V4 10/17] block: ublk_drv: clean up several helpers Ming Lei
2023-03-24 13:58 ` [PATCH V4 11/17] block: ublk_drv: cleanup 'struct ublk_map_data' Ming Lei
2023-03-24 13:58 ` [PATCH V4 12/17] block: ublk_drv: cleanup ublk_copy_user_pages Ming Lei
2023-03-24 13:58 ` [PATCH V4 13/17] block: ublk_drv: grab request reference when the request is handled by userspace Ming Lei
2023-03-24 13:58 ` [PATCH V4 14/17] block: ublk_drv: support to copy any part of request pages Ming Lei
2023-03-24 13:58 ` [PATCH V4 15/17] block: ublk_drv: add read()/write() support for ublk char device Ming Lei
2023-03-24 13:58 ` [PATCH V4 16/17] block: ublk_drv: don't check buffer in case of zero copy Ming Lei
2023-03-24 13:58 ` [PATCH V4 17/17] block: ublk_drv: apply io_uring FUSED_CMD for supporting " Ming Lei
2023-03-28 0:36 ` [PATCH V4 00/17] io_uring/ublk: add IORING_OP_FUSED_CMD Dan Williams
2023-03-28 1:16 ` Ming Lei
2023-03-28 1:29 ` Jens Axboe
2023-03-28 1:35 ` Ming Lei
2023-03-28 1:31 ` Dan Williams
2023-03-28 2:02 ` Ming Lei
2023-03-28 6:32 ` Dan Williams
2023-03-28 3:13 ` Gao Xiang
2023-03-28 3:33 ` Ming Lei
2023-03-28 5:10 ` Kanchan Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox