From: Stefan Roesch <[email protected]>
To: [email protected], [email protected]
Cc: [email protected], [email protected], [email protected],
Olivier Langlois <[email protected]>
Subject: [PATCH v10 3/5] io-uring: add sqpoll support for napi busy poll
Date: Tue, 25 Apr 2023 11:18:43 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
This adds the sqpoll support to the io-uring napi.
Signed-off-by: Stefan Roesch <[email protected]>
Suggested-by: Olivier Langlois <[email protected]>
---
io_uring/napi.c | 25 +++++++++++++++++++++++++
io_uring/napi.h | 2 ++
io_uring/sqpoll.c | 4 ++++
3 files changed, 31 insertions(+)
diff --git a/io_uring/napi.c b/io_uring/napi.c
index bb7d2b6b7e90..0fbdfe5eea06 100644
--- a/io_uring/napi.c
+++ b/io_uring/napi.c
@@ -240,4 +240,29 @@ void io_napi_busy_loop(struct io_ring_ctx *ctx, struct io_wait_queue *iowq)
}
}
+/*
+ * io_napi_sqpoll_busy_poll() - busy poll loop for sqpoll
+ * @ctx: pointer to io-uring context structure
+ *
+ * Splice of the napi list and execute the napi busy poll loop.
+ */
+int io_napi_sqpoll_busy_poll(struct io_ring_ctx *ctx)
+{
+ int ret = 0;
+ LIST_HEAD(napi_list);
+
+ if (!READ_ONCE(ctx->napi_busy_poll_to))
+ return 0;
+
+ spin_lock(&ctx->napi_lock);
+ list_splice_init(&ctx->napi_list, &napi_list);
+ spin_unlock(&ctx->napi_lock);
+
+ if (__io_napi_busy_loop(&napi_list, ctx->napi_prefer_busy_poll))
+ ret = 1;
+
+ io_napi_merge_lists(ctx, &napi_list);
+ return ret;
+}
+
#endif
diff --git a/io_uring/napi.h b/io_uring/napi.h
index 49322a16b6e5..b3455e52170c 100644
--- a/io_uring/napi.h
+++ b/io_uring/napi.h
@@ -17,6 +17,7 @@ void __io_napi_add(struct io_ring_ctx *ctx, struct file *file);
void io_napi_adjust_timeout(struct io_ring_ctx *ctx,
struct io_wait_queue *iowq, struct timespec64 *ts);
void io_napi_busy_loop(struct io_ring_ctx *ctx, struct io_wait_queue *iowq);
+int io_napi_sqpoll_busy_poll(struct io_ring_ctx *ctx);
static inline bool io_napi(struct io_ring_ctx *ctx)
{
@@ -60,6 +61,7 @@ static inline void io_napi_add(struct io_kiocb *req)
#define io_napi_adjust_timeout(ctx, iowq, ts) do {} while (0)
#define io_napi_busy_loop(ctx, iowq) do {} while (0)
+#define io_napi_sqpoll_busy_poll(ctx) (0)
#endif
diff --git a/io_uring/sqpoll.c b/io_uring/sqpoll.c
index 9db4bc1f521a..0c8d53ef134a 100644
--- a/io_uring/sqpoll.c
+++ b/io_uring/sqpoll.c
@@ -15,6 +15,7 @@
#include <uapi/linux/io_uring.h>
#include "io_uring.h"
+#include "napi.h"
#include "sqpoll.h"
#define IORING_SQPOLL_CAP_ENTRIES_VALUE 8
@@ -193,6 +194,9 @@ static int __io_sq_thread(struct io_ring_ctx *ctx, bool cap_entries)
ret = io_submit_sqes(ctx, to_submit);
mutex_unlock(&ctx->uring_lock);
+ if (io_napi(ctx))
+ ret += io_napi_sqpoll_busy_poll(ctx);
+
if (to_submit && wq_has_sleeper(&ctx->sqo_sq_wait))
wake_up(&ctx->sqo_sq_wait);
if (creds)
--
2.39.1
next prev parent reply other threads:[~2023-04-25 18:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 18:18 [PATCH v10 0/5] io_uring: add napi busy polling support Stefan Roesch
2023-04-25 18:18 ` [PATCH v10 1/5] io-uring: move io_wait_queue definition to header file Stefan Roesch
2023-04-25 18:18 ` [PATCH v10 2/5] io-uring: add napi busy poll support Stefan Roesch
2023-04-27 1:41 ` Jens Axboe
2023-04-27 1:46 ` Jens Axboe
2023-04-27 17:34 ` Stefan Roesch
2023-04-27 1:50 ` Jens Axboe
2023-04-27 1:59 ` Jens Axboe
2023-04-27 18:21 ` Stefan Roesch
2023-04-27 17:44 ` Stefan Roesch
2023-04-27 16:27 ` Stefan Roesch
2023-04-28 1:09 ` Jens Axboe
2023-04-27 2:56 ` Ammar Faizi
2023-04-27 11:16 ` Jens Axboe
2023-04-25 18:18 ` Stefan Roesch [this message]
2023-04-25 18:18 ` [PATCH v10 4/5] io_uring: add register/unregister napi function Stefan Roesch
2023-04-25 18:18 ` [PATCH v10 5/5] io_uring: add prefer busy poll to register and unregister napi api Stefan Roesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox