From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9A64C6FD18 for ; Tue, 25 Apr 2023 18:42:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234191AbjDYSmi (ORCPT ); Tue, 25 Apr 2023 14:42:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231356AbjDYSmh (ORCPT ); Tue, 25 Apr 2023 14:42:37 -0400 Received: from 66-220-144-179.mail-mxout.facebook.com (66-220-144-179.mail-mxout.facebook.com [66.220.144.179]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E90765A9 for ; Tue, 25 Apr 2023 11:42:36 -0700 (PDT) Received: by devbig1114.prn1.facebook.com (Postfix, from userid 425415) id 2CEC7442E9CB; Tue, 25 Apr 2023 11:18:53 -0700 (PDT) From: Stefan Roesch To: io-uring@vger.kernel.org, kernel-team@fb.com Cc: shr@devkernel.io, axboe@kernel.dk, ammarfaizi2@gnuweeb.org, Jakub Kicinski Subject: [PATCH v10 4/5] io_uring: add register/unregister napi function Date: Tue, 25 Apr 2023 11:18:44 -0700 Message-Id: <20230425181845.2813854-5-shr@devkernel.io> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230425181845.2813854-1-shr@devkernel.io> References: <20230425181845.2813854-1-shr@devkernel.io> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org This adds an api to register and unregister the napi for io-uring. If the arg value is specified when unregistering, the current napi setting for the busy poll timeout is copied into the user structure. If this is not required, NULL can be passed as the arg value. Signed-off-by: Stefan Roesch Acked-by: Jakub Kicinski --- include/uapi/linux/io_uring.h | 11 ++++++++ io_uring/io_uring.c | 9 +++++++ io_uring/napi.c | 50 +++++++++++++++++++++++++++++++++++ io_uring/napi.h | 13 +++++++++ 4 files changed, 83 insertions(+) diff --git a/include/uapi/linux/io_uring.h b/include/uapi/linux/io_uring.= h index 0716cb17e436..278c1a9de78c 100644 --- a/include/uapi/linux/io_uring.h +++ b/include/uapi/linux/io_uring.h @@ -523,6 +523,10 @@ enum { /* register a range of fixed file slots for automatic slot allocation *= / IORING_REGISTER_FILE_ALLOC_RANGE =3D 25, =20 + /* set/clear busy poll settings */ + IORING_REGISTER_NAPI =3D 26, + IORING_UNREGISTER_NAPI =3D 27, + /* this goes last */ IORING_REGISTER_LAST, =20 @@ -649,6 +653,13 @@ struct io_uring_buf_reg { __u64 resv[3]; }; =20 +/* argument for IORING_(UN)REGISTER_NAPI */ +struct io_uring_napi { + __u32 busy_poll_to; + __u32 pad; + __u64 resv; +}; + /* * io_uring_restriction->opcode values */ diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index fff8f84eb560..c2a291e29475 100644 --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -4417,6 +4417,15 @@ static int __io_uring_register(struct io_ring_ctx = *ctx, unsigned opcode, break; ret =3D io_register_file_alloc_range(ctx, arg); break; + case IORING_REGISTER_NAPI: + ret =3D -EINVAL; + if (!arg) + break; + ret =3D io_register_napi(ctx, arg); + break; + case IORING_UNREGISTER_NAPI: + ret =3D io_unregister_napi(ctx, arg); + break; default: ret =3D -EINVAL; break; diff --git a/io_uring/napi.c b/io_uring/napi.c index 0fbdfe5eea06..56a4754efcfb 100644 --- a/io_uring/napi.c +++ b/io_uring/napi.c @@ -196,6 +196,56 @@ void io_napi_free(struct io_ring_ctx *ctx) spin_unlock(&ctx->napi_lock); } =20 +/* + * io_napi_register() - Register napi with io-uring + * @ctx: pointer to io-uring context structure + * @arg: pointer to io_uring_napi structure + * + * Register napi in the io-uring context. + */ +int io_register_napi(struct io_ring_ctx *ctx, void __user *arg) +{ + const struct io_uring_napi curr =3D { + .busy_poll_to =3D ctx->napi_busy_poll_to, + }; + struct io_uring_napi napi; + + if (copy_from_user(&napi, arg, sizeof(napi))) + return -EFAULT; + if (napi.pad || napi.resv) + return -EINVAL; + + WRITE_ONCE(ctx->napi_busy_poll_to, napi.busy_poll_to); + + if (copy_to_user(arg, &curr, sizeof(curr))) + return -EFAULT; + + return 0; +} + +/* + * io_napi_unregister() - Unregister napi with io-uring + * @ctx: pointer to io-uring context structure + * @arg: pointer to io_uring_napi structure + * + * Unregister napi. If arg has been specified copy the busy poll timeout= and + * prefer busy poll setting to the passed in structure. + */ +int io_unregister_napi(struct io_ring_ctx *ctx, void __user *arg) +{ + const struct io_uring_napi curr =3D { + .busy_poll_to =3D ctx->napi_busy_poll_to, + }; + + if (arg) { + if (copy_to_user(arg, &curr, sizeof(curr))) + return -EFAULT; + } + + WRITE_ONCE(ctx->napi_busy_poll_to, 0); + return 0; +} + /* * io_napi_adjust_timeout() - Add napi id to the busy poll list * @ctx: pointer to io-uring context structure diff --git a/io_uring/napi.h b/io_uring/napi.h index b3455e52170c..8da8f032a441 100644 --- a/io_uring/napi.h +++ b/io_uring/napi.h @@ -12,6 +12,9 @@ void io_napi_init(struct io_ring_ctx *ctx); void io_napi_free(struct io_ring_ctx *ctx); =20 +int io_register_napi(struct io_ring_ctx *ctx, void __user *arg); +int io_unregister_napi(struct io_ring_ctx *ctx, void __user *arg); + void __io_napi_add(struct io_ring_ctx *ctx, struct file *file); =20 void io_napi_adjust_timeout(struct io_ring_ctx *ctx, @@ -50,6 +53,16 @@ static inline void io_napi_free(struct io_ring_ctx *ct= x) { } =20 +static inline int io_register_napi(struct io_ring_ctx *ctx, void __user = *arg) +{ + return -EOPNOTSUPP; +} + +static inline int io_unregister_napi(struct io_ring_ctx *ctx, void __use= r *arg) +{ + return -EOPNOTSUPP; +} + static inline bool io_napi(struct io_ring_ctx *ctx) { return false; --=20 2.39.1