From: Tudor Cretu <[email protected]>
To: [email protected]
Cc: [email protected], [email protected], [email protected],
[email protected], Tudor Cretu <[email protected]>
Subject: [PATCH] io_uring/kbuf: Fix size for shared buffer ring
Date: Thu, 27 Apr 2023 15:31:42 +0100 [thread overview]
Message-ID: <[email protected]> (raw)
The size of the ring is the product of ring_entries and the size of
struct io_uring_buf. Using struct_size is equivalent to
(ring_entries + 1) * sizeof(struct io_uring_buf)
and generates an off-by-one error. Fix it by using size_mul directly.
Signed-off-by: Tudor Cretu <[email protected]>
---
io_uring/kbuf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/io_uring/kbuf.c b/io_uring/kbuf.c
index 4a6401080c1f..9770757c89a0 100644
--- a/io_uring/kbuf.c
+++ b/io_uring/kbuf.c
@@ -505,7 +505,7 @@ int io_register_pbuf_ring(struct io_ring_ctx *ctx, void __user *arg)
}
pages = io_pin_pages(reg.ring_addr,
- struct_size(br, bufs, reg.ring_entries),
+ size_mul(sizeof(struct io_uring_buf), reg.ring_entries),
&nr_pages);
if (IS_ERR(pages)) {
kfree(free_bl);
--
2.34.1
next reply other threads:[~2023-04-27 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 14:31 Tudor Cretu [this message]
2023-04-27 14:35 ` [PATCH] io_uring/kbuf: Fix size for shared buffer ring Jens Axboe
2023-04-27 18:42 ` Jens Axboe
2023-04-28 10:29 ` Tudor Cretu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox