From: Peter Zijlstra <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected], [email protected],
[email protected], [email protected]
Subject: Re: [PATCH 2/7] futex: factor out the futex wake handling
Date: Wed, 12 Jul 2023 10:58:03 +0200 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On Tue, Jul 11, 2023 at 06:47:00PM -0600, Jens Axboe wrote:
> In preparation for having another waker that isn't futex_wake_mark(),
> add a wake handler in futex_q. No extra data is associated with the
> handler outside of struct futex_q itself. futex_wake_mark() is defined as
> the standard wakeup helper, now set through futex_q_init like other
> defaults.
Urgh... so if I understand things right, you're going to replace this
with a custom wake function that does *NOT* put the task on the wake_q.
The wake_q will thus be empty and the task does not get woken up. I'm
presuming someone gets a notification instead somewhere somehow.
I might've been nice to mention some of this somewhere ...
> Signed-off-by: Jens Axboe <[email protected]>
> ---
> kernel/futex/futex.h | 4 ++++
> kernel/futex/requeue.c | 3 ++-
> kernel/futex/waitwake.c | 6 +++---
> 3 files changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/futex/futex.h b/kernel/futex/futex.h
> index d2949fca37d1..8eaf1a5ce967 100644
> --- a/kernel/futex/futex.h
> +++ b/kernel/futex/futex.h
> @@ -69,6 +69,9 @@ struct futex_pi_state {
> union futex_key key;
> } __randomize_layout;
>
> +struct futex_q;
> +typedef void (futex_wake_fn)(struct wake_q_head *wake_q, struct futex_q *q);
> +
> /**
> * struct futex_q - The hashed futex queue entry, one per waiting task
> * @list: priority-sorted list of tasks waiting on this futex
> @@ -98,6 +101,7 @@ struct futex_q {
>
> struct task_struct *task;
> spinlock_t *lock_ptr;
> + futex_wake_fn *wake;
> union futex_key key;
> struct futex_pi_state *pi_state;
> struct rt_mutex_waiter *rt_waiter;
next prev parent reply other threads:[~2023-07-12 8:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 0:46 [PATCHSET 0/7] Add io_uring futex/futexv support Jens Axboe
2023-07-12 0:46 ` [PATCH 1/7] futex: abstract out futex_op_to_flags() helper Jens Axboe
2023-07-12 8:16 ` Peter Zijlstra
2023-07-12 14:59 ` Jens Axboe
2023-07-12 0:47 ` [PATCH 2/7] futex: factor out the futex wake handling Jens Axboe
2023-07-12 8:58 ` Peter Zijlstra [this message]
2023-07-12 15:02 ` Jens Axboe
2023-07-12 0:47 ` [PATCH 3/7] io_uring: add support for futex wake and wait Jens Axboe
2023-07-12 8:51 ` Peter Zijlstra
2023-07-12 15:05 ` Jens Axboe
2023-07-12 0:47 ` [PATCH 4/7] futex: add wake_data to struct futex_q Jens Axboe
2023-07-12 0:47 ` [PATCH 5/7] futex: make futex_parse_waitv() available as a helper Jens Axboe
2023-07-12 9:25 ` Peter Zijlstra
2023-07-12 15:06 ` Jens Axboe
2023-07-12 0:47 ` [PATCH 6/7] futex: make the vectored futex operations available Jens Axboe
2023-07-12 0:47 ` [PATCH 7/7] io_uring: add futex waitv Jens Axboe
2023-07-12 9:31 ` Peter Zijlstra
2023-07-12 15:10 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712085803.GD3100107@hirez.programming.kicks-ass.net \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox